Issue 6351121: use SkTRefArray to share readonly data between pictures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6351121: use SkTRefArray to share readonly data between pictures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by reed1

Modified:
12 years, 3 months ago

Reviewers:
Leon

CC:
skia-review_googlegroups.com, bungeman

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

use SkTRefArray to share readonly data between pictures Committed: https://code.google.com/p/skia/source/detail?r=4720

Patch Set 2 : #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -219 lines)			Patch
M	src/core/SkPictureFlat.h	View	1	2 chunks	+36 lines, -9 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View	1	5 chunks	+8 lines, -16 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	1	10 chunks	+61 lines, -194 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

depends on https://codereview.appspot.com/6422057 for updated version of SkTRefArray

12 years, 3 months ago (2012-07-23 02:10:30 UTC) #2

Leon

https://codereview.appspot.com/6351121/diff/1/src/core/SkPictureFlat.h File src/core/SkPictureFlat.h (right): https://codereview.appspot.com/6351121/diff/1/src/core/SkPictureFlat.h#newcode407 src/core/SkPictureFlat.h:407: * Unflatten the objects and return then in SkTRefArray, ...

12 years, 3 months ago (2012-07-23 14:16:49 UTC) #3

lgtm

Expand All Messages | Collapse All Messages