code review 6351090: cmd/gc: Inline pointer sized T2I interface conversions

src/cmd/gc/walk.c

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 #include        <u.h>
 #include        <libc.h>
 #include        "go.h"
 
 static  Node*   walkprint(Node*, NodeList**, int);
 static  Node*   mapfn(char*, Type*);
@@ skipping 766 matching lines @@
                                 /* For pointer types, we can make a special form of optimization
                                  *
                                  * These statements are put onto the expression init list:
                                  *      Itab *tab = atomicloadtype(&cache);
                                  *      if(tab == nil)
                                  *              tab = typ2Itab(type, itype, &cache);
                                  *
                                  * The CONVIFACE expression is replaced with this:
                                  *      OEFACE{tab, ptr};
                                  */
-                                r = l->left;

[nigeltao, 2012/08/24 05:02:51]

Just use "sym->def" a few lines below instead of assigning to r?

                                 l = temp(ptrto(types[TUINT8]));
 
-                                n1 = nod(OAS, l, r);
+                                n1 = nod(OAS, l, sym->def);
                                 typecheck(&n1, Etop);
                                 *init = list(*init, n1);
 
                                 fn = syslook("typ2Itab", 1);
                                 n1 = nod(OCALL, fn, N);
                                 n1->list = ll;
                                 typecheck(&n1, Erv);
                                 walkexpr(&n1, init);
 
                                 n2 = nod(OIF, N, N);
@@ skipping 2087 matching lines @@
                         bits -= v;
                 }
                 break;
         }
 ········
         if(!sign && bits <= 62 && (1LL<<bits) <= max)
                 return 1;
 ········
         return 0;
 }