Issue 6351082: Make ProgramBinaries binary rather than text + binary.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6351082: Make ProgramBinaries binary rather than text + binary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by apatrick1

Modified:
14 years ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make ProgramBinaries binary rather than text + binary. Committed: https://code.google.com/p/angleproject/source/detail?r=1215

Patch Set 1 #

Total comments: 2

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -115 lines)			Patch
A +	src/libGLESv2/BinaryStream.h	View	2 chunks	+11 lines, -21 lines	0 comments	Download
M	src/libGLESv2/ProgramBinary.cpp	View	8 chunks	+88 lines, -93 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.cpp	View	1 chunk	+20 lines, -1 line	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

Tested as before by running all the WebGL conformance tests and round tripping all the ...

14 years ago (2012-07-10 22:51:43 UTC) #1

dgkoch

14 years ago (2012-07-12 01:16:10 UTC) #2

Nice. Definitely like it better than the text version.

LGTM.

https://codereview.appspot.com/6351082/diff/1/src/libGLESv2/libGLESv2.cpp
File src/libGLESv2/libGLESv2.cpp (right):

https://codereview.appspot.com/6351082/diff/1/src/libGLESv2/libGLESv2.cpp#new...
src/libGLESv2/libGLESv2.cpp:4623: // FIXME: This is a hack for testing. Will not
check in.
On 2012/07/10 22:51:43, apatrick1 wrote:
> I'll remember! :)
:-)

Expand All Messages | Collapse All Messages