Issue 6351076: Added pdf implementation of conical gradient.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6351076: Added pdf implementation of conical gradient. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by rileya

Modified:
12 years, 5 months ago

Reviewers:
Steve VanDeBogart, TomH, bsalomon, robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Added pdf implementation of conical gradient. Also fixed an erroneous comment in the gpu implementation. Committed: https://code.google.com/p/skia/source/detail?r=4520

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+119 lines, -5 lines)			Patch
M	gm/twopointradial.cpp	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrGradientEffects.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFShader.cpp	View	1 2 3	3 chunks	+118 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rileya

Transparency is unsupported with the current way PDF shaders are handled, so it can't properly ...

12 years, 5 months ago (2012-07-10 16:01:12 UTC) #1

Steve VanDeBogart

12 years, 5 months ago (2012-07-10 16:45:47 UTC) #3

LGTM

http://codereview.appspot.com/6351076/diff/3001/src/pdf/SkPDFShader.cpp
File src/pdf/SkPDFShader.cpp (right):

http://codereview.appspot.com/6351076/diff/3001/src/pdf/SkPDFShader.cpp#newco...
src/pdf/SkPDFShader.cpp:284: SkScalar a = SkScalarMul(dx, dx) + SkScalarMul(dy,
dy) - SkScalarMul(dr, dr);
This file is still an 80 column file.

http://codereview.appspot.com/6351076/diff/3001/src/pdf/SkPDFShader.cpp#newco...
src/pdf/SkPDFShader.cpp:582: transformPoints[1].fX += 1;
Sk_Scalar1

Expand All Messages | Collapse All Messages