Issue 6350106: Add a skia method to perform an atomic add.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6350106: Add a skia method to perform an atomic add. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by Leon

Modified:
12 years, 5 months ago

Reviewers:
bungeman

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add a skia method to perform an atomic add. Complements sk_atomic_inc for when you want to increase by more than one. Committed: https://code.google.com/p/skia/source/detail?r=4614

Patch Set 1 #

Patch Set 2 : Added a test case #

Patch Set 3 : Set the processor affinity. #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -3 lines)			Patch
M	gyp/tests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkThread.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkThread_platform.h	View		3 chunks	+15 lines, -2 lines	0 comments	Download
M	src/ports/SkThread_none.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/ports/SkThread_pthread.cpp	View		2 chunks	+14 lines, -0 lines	0 comments	Download
M	src/ports/SkThread_win.cpp	View		2 chunks	+7 lines, -1 line	0 comments	Download
A	tests/AtomicTest.cpp	View	1 2	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

12 years, 5 months ago (2012-07-13 21:21:29 UTC) #3

On 2012/07/13 21:06:17, scroggo-work wrote:
> New patch also sets the processor affinity in the test.

LGTM

Expand All Messages | Collapse All Messages