Issue 6350098: SkHitBox added

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6350098: SkHitBox added (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by chudy

Modified:
11 years, 10 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

SkHitBox added. SkHitBox is a class that determines which draw command is associated with the pixel located at x,y. By calculating a single point instead of the entire bitmap at once there is no visible performance slowdown.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Optimized redraw calls #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+234 lines, -20 lines)			Patch
M	debugger/QT/SkCanvasWidget.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	debugger/QT/SkCanvasWidget.cpp	View	1	4 chunks	+7 lines, -3 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	debugger/QT/SkSettingsWidget.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	debugger/QT/SkSettingsWidget.cpp	View		4 chunks	+20 lines, -1 line	0 comments	Download
M	debugger/QT/moc_SkCanvasWidget.cpp	View		5 chunks	+14 lines, -5 lines	0 comments	Download
M	debugger/QT/moc_SkSettingsWidget.cpp	View		5 chunks	+6 lines, -4 lines	0 comments	Download
M	debugger/SkDebugCanvas.h	View	1	4 chunks	+22 lines, -1 line	0 comments	Download
M	debugger/SkDebugCanvas.cpp	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
A	debugger/SkHitBox.h	View		1 chunk	+81 lines, -0 lines	0 comments	Download
A	debugger/SkHitBox.cpp	View		1 chunk	+66 lines, -0 lines	0 comments	Download
M	gyp/debugger.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

chudy

11 years, 11 months ago (2012-07-11 19:45:59 UTC) #1

Definitely could use suggestions when it comes to naming conventions but it
works. Calculating a single point is pretty much instantaneous, even in debug
mode.

I kept the code to calculate every pixel in there in case we find a cool use for
it but I can trash it as well if nothing comes to mind.

https://codereview.appspot.com/6350098/diff/1/debugger/QT/SkDebuggerGUI.cpp
File debugger/QT/SkDebuggerGUI.cpp (right):

https://codereview.appspot.com/6350098/diff/1/debugger/QT/SkDebuggerGUI.cpp#n...
debugger/QT/SkDebuggerGUI.cpp:74: connect(fSettingsWidget.getCommandCheckBox(),
SIGNAL(toggled(bool)),
This was a bug I fixed that I lumped into this CL for the sake of brevity.

Expand All Messages | Collapse All Messages