Issue 6350071: Added stubs for zoom info panel.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6350071: Added stubs for zoom info panel. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by chudy

Modified:
13 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Added stubs for zoom info panel.

Patch Set 1 #

Patch Set 2 : Connected Scale Factor to info box #

Patch Set 3 : Finishing up SkSettings Widget #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+445 lines, -250 lines)			Patch
M	debugger/QT/SkCanvasWidget.h	View	1 2	2 chunks	+5 lines, -1 line	0 comments	Download
M	debugger/QT/SkCanvasWidget.cpp	View	1 2	6 chunks	+10 lines, -6 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.h	View	1 2	4 chunks	+15 lines, -3 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	1 2	21 chunks	+134 lines, -111 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.h	View	1 2	2 chunks	+34 lines, -15 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.cpp	View	1 2	1 chunk	+105 lines, -60 lines	0 comments	Download
M	debugger/QT/moc_SkCanvasWidget.cpp	View	1 2	3 chunks	+32 lines, -4 lines	0 comments	Download
M	debugger/QT/moc_SkDebuggerGUI.cpp	View	1 2	3 chunks	+62 lines, -45 lines	0 comments	Download
M	debugger/QT/moc_SkInspectorWidget.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	debugger/QT/moc_SkSettingsWidget.cpp	View	1 2	3 chunks	+47 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

fine in general (like I know anything about Qt). Does the scaleFactor need to be ...

13 years ago (2012-07-09 14:01:08 UTC) #3

chudy

13 years ago (2012-07-09 17:54:41 UTC) #4

Changed the int to a float for future potential. Hooked up the rest of the
widgets in SkSettings. 

Am now branching off into multiple CL's for features and bug fixes. Had been
working on this branch before.

Expand All Messages | Collapse All Messages