Issue 6349070: Added a sgpipe benchmark.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6349070: Added a sgpipe benchmark. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by keyar

Modified:
11 years, 10 months ago

Reviewers:
Leon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Added a sgpipe benchmark. Committed http://code.google.com/p/skia/source/detail?r=4490

Patch Set 1 #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -2 lines)			Patch
	M	gyp/tools.gyp	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	tools/bench_pictures_main.cpp	View		4 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

keyar

On 2012/07/09 16:27:51, scroggo-work wrote: > lgtm How, could you commit this for me?

11 years, 10 months ago (2012-07-09 17:00:40 UTC) #4

reed1

On 2012/07/09 17:00:40, keyar wrote: > On 2012/07/09 16:27:51, scroggo-work wrote: > > lgtm > ...

11 years, 10 months ago (2012-07-09 17:04:04 UTC) #5

keyar

11 years, 10 months ago (2012-07-09 17:08:57 UTC) #6

On 2012/07/09 17:04:04, reed1 wrote:
> On 2012/07/09 17:00:40, keyar wrote:
> > On 2012/07/09 16:27:51, scroggo-work wrote:
> > > lgtm
> > 
> > How, could you commit this for me?
> 
> You are now a committer!

Ok, thank you.

Expand All Messages | Collapse All Messages