Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2655)

Issue 6349043: Simple picture benchmarking tool. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by keyar
Modified:
12 years ago
Reviewers:
junov, twiz, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Simple picture benchmarking tool. Committed: http://code.google.com/p/skia/source/detail?r=4375

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -0 lines) Patch
M gyp/tools.gyp View 2 chunks +18 lines, -0 lines 0 comments Download
A tools/bench_pictures_main.cpp View 1 1 chunk +236 lines, -0 lines 0 comments Download

Messages

Total messages: 6
keyar
Please review.
12 years ago (2012-06-26 22:39:22 UTC) #1
reed1
1. Skia's convention is to use fMemberVariable in structs and classes 2. Skia's convention is ...
12 years ago (2012-06-27 16:13:07 UTC) #2
keyar
Updated to reflect reviewer comments.
12 years ago (2012-06-27 18:48:29 UTC) #3
reed1
lgtm (til we start using it :)
12 years ago (2012-06-27 19:11:50 UTC) #4
keyar
On 2012/06/27 19:11:50, reed1 wrote: > lgtm (til we start using it :) Excellent, could ...
12 years ago (2012-06-27 19:16:56 UTC) #5
reed1
12 years ago (2012-06-27 19:33:44 UTC) #6
rev. 4375
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b