Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 6348101: Benchmarking will now reset canvas so transfroms do not acculmulate.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by keyar
Modified:
13 years, 6 months ago
Reviewers:
reed1, junov1, twiz
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Benchmarking will now reset canvas so transfroms do not acculmulate. The reset is performed by saving and restoring the canvases.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M tools/bench_pictures_main.cpp View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4
keyar
13 years, 6 months ago (2012-07-12 15:57:45 UTC) #1
reed1
SkCanvas::drawPicture already does this bracketing, and does it more safely, since it calls restoreToCount()
13 years, 6 months ago (2012-07-12 16:03:03 UTC) #2
keyar
On 2012/07/12 16:03:03, reed1 wrote: > SkCanvas::drawPicture already does this bracketing, and does it more ...
13 years, 6 months ago (2012-07-12 17:28:19 UTC) #3
junov1
13 years, 6 months ago (2012-07-12 17:32:29 UTC) #4
On 2012/07/12 17:28:19, keyar wrote:
> On 2012/07/12 16:03:03, reed1 wrote:
> > SkCanvas::drawPicture already does this bracketing, and does it more safely,
> > since it calls restoreToCount()
> 
> Alright, disregard then.

What about pipe_run?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b