Additions to update-doxygen.sh

* Adding arguments to specify the working directory and whether the script should try to commit at the end.
* Redirecting doxygen output to a last_run_output.txt file.
* Maintaining backwards compatibility.

Context-
This CL is a preparatory CL for the housekeeping slave. The slave will use this script to update Doxygen docs. The script will not be used to commit and instead the slave will call AddMergeIntoSvn to commit.
Committed: https://code.google.com/p/skia/source/detail?r=4495

[epoger, 2012-07-09 14:49:54]

https://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh
File tools/update-doxygen.sh (right):

https://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh#newc...
tools/update-doxygen.sh:6: # The first argument is the directory trunk and docs
will be checked out in and
IMHO, the first sentence would be clearer if rearranged like this:

The first argument is the working directory within which we will check out the
code, generate documentation, and store the doxygen log.  (by default,
/tmp/skia-doxygen)

https://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh#newc...
tools/update-doxygen.sh:16: TEMPDIR=/tmp/skia-doxygen
Alternatively, change this to 

TEMPDIR=${TEMPDIR:-/tmp/skia-doxygen}

and then the caller can override the default value (if he wants to) like this:

TEMPDIR=/another/path tools/update-doxygen.sh

I somewhat prefer this alternate method, because the caller can specify things
using name/value pairs rather than depending on order of parameters in the
command line.  But if you prefer keeping it as-is, that's fine with me.

https://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh#newc...
tools/update-doxygen.sh:31: doxygen Doxyfile &> ../docs/last_run_output.txt
When this is running within a build slave, wouldn't it be better to just let the
output go to stdout/stderr so that it is visible via the waterfall UI?

https://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh#newc...
tools/update-doxygen.sh:66: if $COMMIT ; then
Is this checking for "false", empty-string, or what?

[rmistry, 2012-07-09 19:31:42]

I am also now outputting modified/added documentation files at the end of the
script.

http://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh
File tools/update-doxygen.sh (right):

http://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh#newcode6
tools/update-doxygen.sh:6: # The first argument is the directory trunk and docs
will be checked out in and
On 2012/07/09 14:49:54, epoger wrote:
> IMHO, the first sentence would be clearer if rearranged like this:
> 
> The first argument is the working directory within which we will check out the
> code, generate documentation, and store the doxygen log.  (by default,
> /tmp/skia-doxygen)

Done.

http://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh#newco...
tools/update-doxygen.sh:16: TEMPDIR=/tmp/skia-doxygen
On 2012/07/09 14:49:54, epoger wrote:
> Alternatively, change this to 
> 
> TEMPDIR=${TEMPDIR:-/tmp/skia-doxygen}
> 
> and then the caller can override the default value (if he wants to) like this:
> 
> TEMPDIR=/another/path tools/update-doxygen.sh
> 
> I somewhat prefer this alternate method, because the caller can specify things
> using name/value pairs rather than depending on order of parameters in the
> command line.  But if you prefer keeping it as-is, that's fine with me.

Done.

http://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh#newco...
tools/update-doxygen.sh:31: doxygen Doxyfile &> ../docs/last_run_output.txt
On 2012/07/09 14:49:54, epoger wrote:
> When this is running within a build slave, wouldn't it be better to just let
the
> output go to stdout/stderr so that it is visible via the waterfall UI?

After reading your comment I changed it to output both in stdout and file, but
the last_run_output.txt file always had changes even when the rest of the
documentation had no changes which resulted in an unnecessary commit.
It now outputs only to stdout/stderr.

http://codereview.appspot.com/6348076/diff/2001/tools/update-doxygen.sh#newco...
tools/update-doxygen.sh:66: if $COMMIT ; then
On 2012/07/09 14:49:54, epoger wrote:
> Is this checking for "false", empty-string, or what?

This is checking for "false", improved the sample usage in the documentation
above.

[epoger, 2012-07-09 20:12:46]

LGTM

Nice, thanks!