Issue 6348059: Properly handle extracted bitmaps in cross process/shared addr space SkGPipe.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6348059: Properly handle extracted bitmaps in cross process/shared addr space SkGPipe. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Leon

Modified:
12 years, 3 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Properly handle extracted bitmaps in cross process/shared addr space SkGPipe. Use the pixel ref which we have already copied and the appropriate pixel ref offset. Turn SampleDrawBitmap into a GM to test this functionality.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Naming changes for clarity. #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -111 lines)			Patch
A +	gm/extractbitmap.cpp	View	1	3 chunks	+20 lines, -18 lines	0 comments	Download
M	gyp/SampleApp.gyp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/gmslides.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
D	samplecode/SampleDrawBitmap.cpp	View		1 chunk	+0 lines, -84 lines	0 comments	Download
M	src/pipe/SkGPipeWrite.cpp	View	1	2 chunks	+25 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

lgtm w/ naming suggestions https://codereview.appspot.com/6348059/diff/1/src/pipe/SkGPipeWrite.cpp File src/pipe/SkGPipeWrite.cpp (right): https://codereview.appspot.com/6348059/diff/1/src/pipe/SkGPipeWrite.cpp#newcode85 src/pipe/SkGPipeWrite.cpp:85: const uint32_t genID = bm.getGenerationID(); ...

12 years, 3 months ago (2012-06-29 20:56:14 UTC) #3

Leon

12 years, 3 months ago (2012-06-29 21:07:05 UTC) #4

https://codereview.appspot.com/6348059/diff/1/src/pipe/SkGPipeWrite.cpp
File src/pipe/SkGPipeWrite.cpp (right):

https://codereview.appspot.com/6348059/diff/1/src/pipe/SkGPipeWrite.cpp#newco...
src/pipe/SkGPipeWrite.cpp:85: const uint32_t genID = bm.getGenerationID();
On 2012/06/29 20:56:14, reed1 wrote:
> possibly rename "sharedPixelRef"?

Done.

https://codereview.appspot.com/6348059/diff/1/src/pipe/SkGPipeWrite.cpp#newco...
src/pipe/SkGPipeWrite.cpp:109: copy = new SkBitmap(bm);
On 2012/06/29 20:56:14, reed1 wrote:
> s/Set/Replace

Done.

Expand All Messages | Collapse All Messages