Issue 6348056: Make sure that #version occurs before anything else, except for comments and white space.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6348056: Make sure that #version occurs before anything else, except for comments and white space. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by Alok Priyadarshi

Modified:
12 years, 2 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make sure that #version occurs before anything else, except for comments and white space. Committed: https://code.google.com/p/angleproject/source/detail?r=1184

Patch Set 1 #

Patch Set 2 : #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+155 lines, -0 lines)			Patch
M	src/compiler/preprocessor/new/Diagnostics.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/Diagnostics.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.cpp	View	5 chunks	+18 lines, -0 lines	0 comments	Download
M	tests/preprocessor_tests/version_test.cpp	View	1 chunk	+132 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

LGTM Are we going to properly reject WebGL shaders attempting to pass in unsupported #version ...

12 years, 2 months ago (2012-06-29 23:29:09 UTC) #2

Alok Priyadarshi

12 years, 2 months ago (2012-06-30 00:43:36 UTC) #3

On 2012/06/29 23:29:09, kbr1 wrote:
> LGTM
> 
> Are we going to properly reject WebGL shaders attempting to pass in
unsupported
> #version directives? Is this handled today?

Yes. Nothing here changes. If #version has correct format, the new preprocessor
just calls a callback for the compiler to handle.

Expand All Messages | Collapse All Messages