Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(625)

Issue 6347066: skdiff now has the option to not print out the directories it is using. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by keyar
Modified:
12 years, 5 months ago
Reviewers:
epoger, TomH
CC:
skia-review_googlegroups.com, benchen, rmistry
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

skdiff now has the option to not print out the directories it is using. Further, test_pictures.py will call skdiff with this option. Committed http://code.google.com/p/skia/source/detail?r=4497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M tools/skdiff_main.cpp View 4 chunks +19 lines, -4 lines 0 comments Download
M tools/test_pictures.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
keyar
12 years, 5 months ago (2012-07-09 17:47:45 UTC) #1
reed1
tom is your man
12 years, 5 months ago (2012-07-09 18:22:57 UTC) #2
TomH
LGTM. The important thing is that the default behavior isn't changed, since the bots rely ...
12 years, 5 months ago (2012-07-09 18:26:35 UTC) #3
keyar
cc'ed bensong, rmistry, epoger so you three can be aware of this change if you ...
12 years, 5 months ago (2012-07-09 19:05:24 UTC) #4
epoger
12 years, 5 months ago (2012-07-09 20:15:26 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b