Issue 6346100: [PDF] Add link annotations.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6346100: [PDF] Add link annotations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by Steve VanDeBogart

Modified:
12 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

[PDF] Add link annotations. Committed: https://code.google.com/p/skia/source/detail?r=4609

Patch Set 2 : Address Comments #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -5 lines)			Patch
M	include/pdf/SkPDFDevice.h	View		4 chunks	+9 lines, -0 lines	0 comments	Download
M	include/pdf/SkPDFDocument.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/core/SkAnnotation.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1	5 chunks	+62 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pdf/SkPDFStream.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/AnnotationTest.cpp	View		2 chunks	+48 lines, -0 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

https://codereview.appspot.com/6346100/diff/1/src/core/SkAnnotation.cpp File src/core/SkAnnotation.cpp (left): https://codereview.appspot.com/6346100/diff/1/src/core/SkAnnotation.cpp#oldcode25 src/core/SkAnnotation.cpp:25: oops, thanks. https://codereview.appspot.com/6346100/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.appspot.com/6346100/diff/1/src/pdf/SkPDFDevice.cpp#newcode1192 src/pdf/SkPDFDevice.cpp:1192: } ...

12 years, 2 months ago (2012-07-13 14:38:47 UTC) #2

Steve VanDeBogart

https://codereview.appspot.com/6346100/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): https://codereview.appspot.com/6346100/diff/1/src/pdf/SkPDFDevice.cpp#newcode1192 src/pdf/SkPDFDevice.cpp:1192: } On 2012/07/13 14:38:47, reed1 wrote: > Can you ...

12 years, 2 months ago (2012-07-13 18:48:02 UTC) #3

reed1

12 years, 2 months ago (2012-07-13 19:03:31 UTC) #4

lgtm

-- next round, we should start using SkNEW and SkNEW_ARGS ... (but not needed in
this CL)

Expand All Messages | Collapse All Messages