Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1130)

Issue 6346094: Update binaries from syzygy-0-1 release branch (0.1.15.0) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Roger McFarlane
Modified:
12 years, 6 months ago
Reviewers:
chrisha, Siggi
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Update binaries from syzygy-0-1 release branch (0.1.15.0) These files are from a local release build of svn branch syzygy-0-1 post the change to warn on truncated segments. BUG= TEST= Committed: https://code.google.com/p/sawbuck/source/detail?r=991

Patch Set 1 : Initial CL #

Total comments: 3

Patch Set 2 : Fix generated batch files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-13 lines, --13 lines) Patch
D syzygy/binaries/Benchmark_Chrome-0.1_r785-py2.6.egg View 0 chunks +-1 lines, --1 lines 0 comments Download
A syzygy/binaries/Benchmark_Chrome-0.1_r990-py2.6.egg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/ETW-0.6.5.0-py2.6.egg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/ETW_Db-0.1_r559-py2.6.egg View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/benchmark.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M syzygy/binaries/exe/call_trace.dll View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/call_trace_client.dll View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/call_trace_control.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/call_trace_service.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/instrument.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/msdia90.dll View 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/profile_client.dll View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/relink.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/reorder.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/run_in_snapshot.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/run_in_snapshot_x64.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/run_in_snapshot_xp.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/exe/wsdump.exe View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M syzygy/binaries/instrument.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M syzygy/binaries/optimize.bat View 1 1 chunk +1 line, -1 line 0 comments Download
M syzygy/binaries/profile.bat View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
Roger McFarlane
PTAL
12 years, 6 months ago (2012-07-12 16:03:53 UTC) #1
chrisha
One little problem... https://codereview.appspot.com/6346094/diff/2001/syzygy/binaries/benchmark.bat File syzygy/binaries/benchmark.bat (left): https://codereview.appspot.com/6346094/diff/2001/syzygy/binaries/benchmark.bat#oldcode18 syzygy/binaries/benchmark.bat:18: exit /b %ERRORLEVEL% This change needs ...
12 years, 6 months ago (2012-07-12 16:06:42 UTC) #2
chrisha
https://codereview.appspot.com/6346094/diff/2001/syzygy/binaries/instrument.bat File syzygy/binaries/instrument.bat (left): https://codereview.appspot.com/6346094/diff/2001/syzygy/binaries/instrument.bat#oldcode18 syzygy/binaries/instrument.bat:18: exit /b %ERRORLEVEL% And here... (etc) This should be ...
12 years, 6 months ago (2012-07-12 16:07:50 UTC) #3
Roger McFarlane
A revised CL will be uploaded shortly. https://codereview.appspot.com/6346094/diff/2001/syzygy/binaries/instrument.bat File syzygy/binaries/instrument.bat (left): https://codereview.appspot.com/6346094/diff/2001/syzygy/binaries/instrument.bat#oldcode18 syzygy/binaries/instrument.bat:18: exit /b ...
12 years, 6 months ago (2012-07-12 16:15:45 UTC) #4
Roger McFarlane
PTAL?
12 years, 6 months ago (2012-07-12 17:29:11 UTC) #5
chrisha
lgtm!
12 years, 6 months ago (2012-07-12 17:32:15 UTC) #6
Roger McFarlane
12 years, 6 months ago (2012-07-12 17:33:03 UTC) #7
Thanks, committing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b