IBusBus: honor new connect-async prop in the socket monitor callback

IBusBus: honor new connect-async prop in the socket monitor callback

I think we should make use of the async connection here if the
property is set.

But we also need a new flag for ongoing async connection attempts
because the socket monitor callback may be called several times before
the connection is established.

BUG=http://code.google.com/p/ibus/issues/detail?id=1482
TEST=

[Peng, 2012-07-12 15:07:30]

https://codereview.appspot.com/6346090/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

https://codereview.appspot.com/6346090/diff/1/src/ibusbus.c#newcode359
src/ibusbus.c:359: !bus->priv->async_connection_ongoing) {
If during connecting, the ibus-daemon is killed, and a new ibus-daemon is
launched. What will happen?

Maybe _changed_cb() will call ibus_bus_connect_async() again, but the
async_connection_ongoing is still true. It could be a bug.

Maybe it is better to keep the address of ibus-daemon, if the address is
changed, we should cancel previous ongoing connect operation, and issue a new
one.

https://codereview.appspot.com/6346090/diff/1/src/ibusbus.c#newcode401
src/ibusbus.c:401: if (bus->priv->connect_async)
I think we should always use ibus_bus_connect_async() to avoid IO block.

[TiagoMatos, 2012-07-12 18:19:04]

Thanks for the review.

I agree that we should always connect asynchronously. The issue you pointed out
should be fixed here as well.

[Peng, 2012-07-12 20:43:27]

On 2012/07/12 18:19:04, TiagoMatos wrote:
> Thanks for the review.
> 
> I agree that we should always connect asynchronously. The issue you pointed
out
> should be fixed here as well.

I modified this CL a little bit, and landed it. Please close it. Thanks for your
work.