Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(103)

Issue 6346086: Fix issue #160. Refresh SignedJwtAssertionCredentials w/Storage. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by jcgregorio_google
Modified:
12 years, 12 months ago
Reviewers:
aiuto
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Description

Fixes refreshing a SignedJwtAssertionCredentials w/Storage. There were two issues, first private_key was binary and not serializable into JSON, and secondly the access_token wasn't being restored when reading from JSON. Also fix up some logging to use named loggers. Fixes issue #160.

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -13 lines) Patch
M oauth2client/appengine.py View 4 chunks +6 lines, -3 lines 0 comments Download
M oauth2client/client.py View 3 chunks +12 lines, -8 lines 2 comments Download
M oauth2client/crypt.py View 2 chunks +3 lines, -1 line 0 comments Download
M tests/test_oauth2client_jwt.py View 4 chunks +63 lines, -1 line 4 comments Download

Messages

Total messages: 5
jcgregorio_google
12 years, 12 months ago (2012-07-11 14:31:32 UTC) #1
aiuto
lgtm http://codereview.appspot.com/6346086/diff/1/oauth2client/client.py File oauth2client/client.py (right): http://codereview.appspot.com/6346086/diff/1/oauth2client/client.py#newcode828 oauth2client/client.py:828: do you need this blank line? http://codereview.appspot.com/6346086/diff/1/tests/test_oauth2client_jwt.py File ...
12 years, 12 months ago (2012-07-11 18:46:53 UTC) #2
jcgregorio_google
http://codereview.appspot.com/6346086/diff/1/oauth2client/client.py File oauth2client/client.py (right): http://codereview.appspot.com/6346086/diff/1/oauth2client/client.py#newcode828 oauth2client/client.py:828: No. Removed. On 2012/07/11 18:46:53, aiuto wrote: > do ...
12 years, 12 months ago (2012-07-11 19:31:45 UTC) #3
aiuto
lgtm again
12 years, 12 months ago (2012-07-11 19:34:11 UTC) #4
jcgregorio_google
12 years, 12 months ago (2012-07-11 19:36:28 UTC) #5
Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=59a3057af22...

On 2012/07/11 19:31:45, jcgregorio_google wrote:
> http://codereview.appspot.com/6346086/diff/1/oauth2client/client.py
> File oauth2client/client.py (right):
> 
> http://codereview.appspot.com/6346086/diff/1/oauth2client/client.py#newcode828
> oauth2client/client.py:828: 
> No. Removed.
> 
> On 2012/07/11 18:46:53, aiuto wrote:
> > do you need this blank line?
> 
> http://codereview.appspot.com/6346086/diff/1/tests/test_oauth2client_jwt.py
> File tests/test_oauth2client_jwt.py (right):
> 
>
http://codereview.appspot.com/6346086/diff/1/tests/test_oauth2client_jwt.py#n...
> tests/test_oauth2client_jwt.py:232: private_key = datafile('privatekey.p12')
> It actually must be a valid p12 file as the underlying signing code gets
called.
> 
> On 2012/07/11 18:46:53, aiuto wrote:
> > Just a question. Does this test flow actually verify the private_key is p12,
> or
> > could you used any valid base64 encoded string here?
> 
>
http://codereview.appspot.com/6346086/diff/1/tests/test_oauth2client_jwt.py#n...
> tests/test_oauth2client_jwt.py:257: 
> On 2012/07/11 18:46:53, aiuto wrote:
> > either no blank here, or put it in at line 239
> 
> Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b