Issue 6346074: [mux] Post bug fix and cleanup after r646

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6346074: [mux] Post bug fix and cleanup after r646 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bashi

Modified:
13 years, 2 months ago

Reviewers:
tyoshino (chromium.org), Takashi Toyoshima

Base URL:
https://pywebsocket.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

[mux] Post bug fix and cleanup after r646 - _LogicalStream._send_closing_handshake must create outer frame. - Rewrite _LogicalStream.receive_message(). Just call Stream.receive_message() and catch a mux specific exception. - Fix comment. - Simplify error check. BUG=none TEST=test/run_all.py

Patch Set 1 #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -50 lines)			Patch
	M	src/mod_pywebsocket/mux.py	View		3 chunks	+16 lines, -50 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages