Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(144)

Issue 6346073: [Issue 544] Fusion Tables API Java Sample (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Christian Junk
Modified:
13 years, 3 months ago
Reviewers:
rmistry
Base URL:
https://code.google.com/p/google-api-java-client.samples/
Visibility:
Public.

Description

[Issue 544] Fusion Tables API Java Sample

Patch Set 1 #

Total comments: 7

Patch Set 2 : Changes after first review #

Total comments: 1

Patch Set 3 : Minor changes after second review #

Messages

Total messages: 20
Christian Junk
13 years, 5 months ago (2012-07-05 12:50:48 UTC) #1
rmistry
Some minor comments, looks great so far! http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/logging.properties File fusiontables-cmdline-sample/logging.properties (right): http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/logging.properties#newcode3 fusiontables-cmdline-sample/logging.properties:3: # -Djava.util.logging.config.file=${project_loc:plus-cmdline-sample}/logging.properties ...
13 years, 5 months ago (2012-07-09 17:58:31 UTC) #2
Christian Junk
Great. Thank you. I will fix all the issues tomorrow and send an update. Regards, ...
13 years, 5 months ago (2012-07-09 20:27:14 UTC) #3
Christian Junk
13 years, 5 months ago (2012-07-12 19:12:52 UTC) #4
Christian Junk
13 years, 5 months ago (2012-07-12 19:16:23 UTC) #5
rmistry
LGTM Thanks!
13 years, 5 months ago (2012-07-13 12:05:52 UTC) #6
rmistry
http://codereview.appspot.com/6346073/diff/16001/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java File fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java (right): http://codereview.appspot.com/6346073/diff/16001/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java#newcode105 fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java:105: One last comment. Here can you add something like: ...
13 years, 5 months ago (2012-07-13 12:10:35 UTC) #7
Christian Junk
13 years, 4 months ago (2012-07-19 12:04:44 UTC) #8
rmistry
LGTM!
13 years, 4 months ago (2012-07-19 12:08:52 UTC) #9
Christian Junk
What are the next steps? Is there anything I can do at the moment? Regards, ...
13 years, 4 months ago (2012-07-25 13:10:46 UTC) #10
rmistry
Next step is to commit your sample: http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Committing_the_code
13 years, 4 months ago (2012-07-25 13:18:48 UTC) #11
rmistry
On 2012/07/25 13:18:48, rmistry wrote: > Next step is to commit your sample: > http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Committing_the_code ...
13 years, 4 months ago (2012-07-25 13:19:12 UTC) #12
Christian Junk
Hi! I'm getting a *403: Forbidden* when trying to push the sample: [image: Inline image ...
13 years, 4 months ago (2012-07-26 19:51:42 UTC) #13
rmistry
I had added christian@christianjunk.de as a contributor a while back. Did you use your https://code.google.com/hosting/settings ...
13 years, 4 months ago (2012-07-27 19:03:00 UTC) #14
Christian Junk
Sorry, wasting your time and causing so much trouble ;( But I nearly spent an ...
13 years, 4 months ago (2012-07-28 18:21:12 UTC) #15
rmistry
Hi Christian, Sorry to hear you are having trouble submitting. Comparing your .hgrc with mine ...
13 years, 4 months ago (2012-07-30 11:10:44 UTC) #16
Christian Junk
Hi Ravi, I'm giving up ;( Today I installed Ubuntu on a Virtual Machine. I ...
13 years, 4 months ago (2012-08-06 10:22:58 UTC) #17
rmistry
Submitted in http://code.google.com/p/google-api-java-client/source/detail?r=d37c1d4095f0b48f6c777340890d017db7fd7090&repo=samples Sorry for the problems you had submitting, and thank you for the ...
13 years, 4 months ago (2012-08-06 12:05:13 UTC) #18
rmistry
Since this is submitted, could you please close this issue? (click on edit and then ...
13 years, 3 months ago (2012-08-27 20:33:47 UTC) #19
Christian Junk
13 years, 3 months ago (2012-08-27 20:36:09 UTC) #20
Done ;)

On Mon, Aug 27, 2012 at 10:33 PM, <rmistry@google.com> wrote:

> Since this is submitted, could you please close this issue? (click on
> edit and then close)
>
> Thanks!
>
>
http://codereview.appspot.com/**6346073/<http://codereview.appspot.com/6346073/>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b