|
|
|
Created:
13 years, 5 months ago by Christian Junk Modified:
13 years, 3 months ago Reviewers:
rmistry Base URL:
https://code.google.com/p/google-api-java-client.samples/ Visibility:
Public. |
Description[Issue 544] Fusion Tables API Java Sample
Patch Set 1 #
Total comments: 7
Patch Set 2 : Changes after first review #
Total comments: 1
Patch Set 3 : Minor changes after second review #MessagesTotal messages: 20
Sign in to reply to this message.
Some minor comments, looks great so far! http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/logg... File fusiontables-cmdline-sample/logging.properties (right): http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/logg... fusiontables-cmdline-sample/logging.properties:3: # -Djava.util.logging.config.file=${project_loc:plus-cmdline-sample}/logging.properties plus -> fusiontables http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/... File fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java (right): http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/... fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java:58: // set up global Plus instance Plus -> FusionTables http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/... fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java:90: } catch (IllegalArgumentException e) { I am trying to get http://code.google.com/p/google-api-java-client/issues/detail?id=545 resolved so that we can remove this block. http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/... fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java:144: + " (Text,Number,Location,Date) VALUES ('Google Inc', 1, '1600 Amphitheatre Parkway Mountain View, CA 94043, USA','" line is > 100. Please break it up. http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/... File fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/View.java (right): http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/... fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/View.java:2: * Copyright (c) 2011 Google Inc. 2012 http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/... fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/View.java:23: * @author Christian Junk Should be ok to have only your name here. http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/... fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/View.java:33: static void header2(String name) { Since this is not used in FusionTablesSample lets remove it and rename header1 -> header
Sign in to reply to this message.
Great. Thank you. I will fix all the issues tomorrow and send an update. Regards, Christian On Mon, Jul 9, 2012 at 7:58 PM, <rmistry@google.com> wrote: > Some minor comments, looks great so far! > > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/logging.**properties<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/logging.properties> > File fusiontables-cmdline-sample/**logging.properties (right): > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/logging.**properties#newcode3<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/logging.properties#newcode3> > fusiontables-cmdline-sample/**logging.properties:3: # > -Djava.util.logging.config.**file=${project_loc:plus-** > cmdline-sample}/logging.**properties > plus -> fusiontables > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/src/main/java/**com/google/api/services/** > samples/fusiontables/cmdline/**FusionTablesSample.java<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java> > File > fusiontables-cmdline-sample/**src/main/java/com/google/api/** > services/samples/fusiontables/**cmdline/FusionTablesSample.**java > (right): > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/src/main/java/**com/google/api/services/** > samples/fusiontables/cmdline/**FusionTablesSample.java#**newcode58<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java#newcode58> > fusiontables-cmdline-sample/**src/main/java/com/google/api/** > services/samples/fusiontables/**cmdline/FusionTablesSample.**java:58: > // set up global Plus instance > Plus -> FusionTables > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/src/main/java/**com/google/api/services/** > samples/fusiontables/cmdline/**FusionTablesSample.java#**newcode90<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java#newcode90> > fusiontables-cmdline-sample/**src/main/java/com/google/api/** > services/samples/fusiontables/**cmdline/FusionTablesSample.**java:90: > } catch (IllegalArgumentException e) { > I am trying to get > http://code.google.com/p/**google-api-java-client/issues/**detail?id=545<http... > resolved so that we can remove this block. > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/src/main/java/**com/google/api/services/** > samples/fusiontables/cmdline/**FusionTablesSample.java#**newcode144<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java#newcode144> > fusiontables-cmdline-sample/**src/main/java/com/google/api/** > services/samples/fusiontables/**cmdline/FusionTablesSample.**java:144: > + " (Text,Number,Location,Date) VALUES ('Google Inc', 1, '1600 > Amphitheatre Parkway Mountain View, CA 94043, USA','" > line is > 100. Please break it up. > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/src/main/java/**com/google/api/services/** > samples/fusiontables/cmdline/**View.java<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/View.java> > File > fusiontables-cmdline-sample/**src/main/java/com/google/api/** > services/samples/fusiontables/**cmdline/View.java > (right): > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/src/main/java/**com/google/api/services/** > samples/fusiontables/cmdline/**View.java#newcode2<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/View.java#newcode2> > fusiontables-cmdline-sample/**src/main/java/com/google/api/** > services/samples/fusiontables/**cmdline/View.java:2: > * Copyright (c) 2011 Google Inc. > 2012 > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/src/main/java/**com/google/api/services/** > samples/fusiontables/cmdline/**View.java#newcode23<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/View.java#newcode23> > fusiontables-cmdline-sample/**src/main/java/com/google/api/** > services/samples/fusiontables/**cmdline/View.java:23: > * @author Christian Junk > Should be ok to have only your name here. > > http://codereview.appspot.com/**6346073/diff/1/fusiontables-** > cmdline-sample/src/main/java/**com/google/api/services/** > samples/fusiontables/cmdline/**View.java#newcode33<http://codereview.appspot.com/6346073/diff/1/fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/View.java#newcode33> > fusiontables-cmdline-sample/**src/main/java/com/google/api/** > services/samples/fusiontables/**cmdline/View.java:33: > static void header2(String name) { > Since this is not used in FusionTablesSample lets remove it and rename > header1 -> header > > http://codereview.appspot.com/**6346073/<http://codereview.appspot.com/6346073/> >
Sign in to reply to this message.
Sign in to reply to this message.
Sign in to reply to this message.
LGTM Thanks!
Sign in to reply to this message.
http://codereview.appspot.com/6346073/diff/16001/fusiontables-cmdline-sample/... File fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java (right): http://codereview.appspot.com/6346073/diff/16001/fusiontables-cmdline-sample/... fusiontables-cmdline-sample/src/main/java/com/google/api/services/samples/fusiontables/cmdline/FusionTablesSample.java:105: One last comment. Here can you add something like: if (tablelist.getItems() == null || tablelist.getItems().isEmpty()) { System.out.println("No tables found!"); return; }
Sign in to reply to this message.
Sign in to reply to this message.
LGTM!
Sign in to reply to this message.
What are the next steps? Is there anything I can do at the moment? Regards, Christian On Thu, Jul 19, 2012 at 2:08 PM, <rmistry@google.com> wrote: > LGTM! > > http://codereview.appspot.com/**6346073/<http://codereview.appspot.com/6346073/> >
Sign in to reply to this message.
Next step is to commit your sample: http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Com...
Sign in to reply to this message.
On 2012/07/25 13:18:48, rmistry wrote: > Next step is to commit your sample: > http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Com... Let me know if you run into any permissions issues.
Sign in to reply to this message.
Hi! I'm getting a *403: Forbidden* when trying to push the sample: [image: Inline image 1] Regards, Christian On Wed, Jul 25, 2012 at 3:19 PM, <rmistry@google.com> wrote: > On 2012/07/25 13:18:48, rmistry wrote: > >> Next step is to commit your sample: >> > > http://code.google.com/p/**google-api-java-client/wiki/** > BecomingAContributor#**Committing_the_code<http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Committing_the_code> > > Let me know if you run into any permissions issues. > > http://codereview.appspot.com/**6346073/<http://codereview.appspot.com/6346073/> >
Sign in to reply to this message.
I had added christian@christianjunk.de as a contributor a while back. Did you use your https://code.google.com/hosting/settings password while pushing? On 2012/07/26 19:51:42, Christian Junk wrote: > Hi! > > I'm getting a *403: Forbidden* when trying to push the sample: > > [image: Inline image 1] > > Regards, > Christian > > On Wed, Jul 25, 2012 at 3:19 PM, <mailto:rmistry@google.com> wrote: > > > On 2012/07/25 13:18:48, rmistry wrote: > > > >> Next step is to commit your sample: > >> > > > > http://code.google.com/p/**google-api-java-client/wiki/** > > > BecomingAContributor#**Committing_the_code<http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Committing_the_code> > > > > Let me know if you run into any permissions issues. > > > > > http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346...> > >
Sign in to reply to this message.
Sorry, wasting your time and causing so much trouble ;( But I nearly spent an hour and I am still not able to push my changes: I regenerated my password. Now I am getting a 404: Not found (please see attachment) Here's my .hgrc file [paths] default = https://code.google.com/p/google-api-java-client.samples/ [ui] username = Christian Junk <christian@christianjunk.de> schemes = https [auth] google-api-java-client.prefix = https://code.google.com/p/google-api-java-client.samples/ google-api-java-client.username = christian@christianjunk.de google-api-java-client.password = [web] allow_push = * push_ssl = True What am I missing here? Kind regards, Christian On Fri, Jul 27, 2012 at 9:03 PM, <rmistry@google.com> wrote: > I had added christian@christianjunk.de as a contributor a while back. > Did you use your https://code.google.com/**hosting/settings<https://code.google.com/hosting/se... while > pushing? > > > On 2012/07/26 19:51:42, Christian Junk wrote: > >> Hi! >> > > I'm getting a *403: Forbidden* when trying to push the sample: >> > > [image: Inline image 1] >> > > Regards, >> Christian >> > > On Wed, Jul 25, 2012 at 3:19 PM, <mailto:rmistry@google.com> wrote: >> > > > On 2012/07/25 13:18:48, rmistry wrote: >> > >> >> Next step is to commit your sample: >> >> >> > >> > http://code.google.com/p/****google-api-java-client/wiki/**<http://code.googl... >> > >> > > BecomingAContributor#****Committing_the_code<http://** > code.google.com/p/google-api-**java-client/wiki/**BecomingAContributor#** > Committing_the_code<http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Committing_the_code> > > > > > >> > Let me know if you run into any permissions issues. >> > >> > >> > > http://codereview.appspot.com/****6346073/%3Chttp://** > codereview.appspot.com/**6346073/<http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346073/> > > > >> > >> > > > http://codereview.appspot.com/**6346073/<http://codereview.appspot.com/6346073/> >
Sign in to reply to this message.
Hi Christian, Sorry to hear you are having trouble submitting. Comparing your .hgrc with mine I see a difference in google-api-java-client.prefix : [ui] username = Ravi Mistry <rmistry@google.com> [auth] google-api-java-client.prefix = https://google-api-java-client.googlecode.com/hg/ google-api-java-client.username = rmistry@google.com google-api-java-client.password = ... On 2012/07/28 18:21:12, Christian Junk wrote: > Sorry, wasting your time and causing so much trouble ;( But I nearly spent > an hour and I am still not able to push my changes: > > I regenerated my password. Now I am getting a 404: Not found (please see > attachment) > > Here's my .hgrc file > > [paths] > default = https://code.google.com/p/google-api-java-client.samples/ > > [ui] > username = Christian Junk <mailto:christian@christianjunk.de> > schemes = https > > [auth] > google-api-java-client.prefix = > https://code.google.com/p/google-api-java-client.samples/ > google-api-java-client.username = mailto:christian@christianjunk.de > google-api-java-client.password = > > [web] > allow_push = * > push_ssl = True > > What am I missing here? > > Kind regards, > Christian > > On Fri, Jul 27, 2012 at 9:03 PM, <mailto:rmistry@google.com> wrote: > > > I had added mailto:christian@christianjunk.de as a contributor a while back. > > Did you use your > https://code.google.com/**hosting/settings%3Chttps://code.google.com/hosting/... > while > > pushing? > > > > > > On 2012/07/26 19:51:42, Christian Junk wrote: > > > >> Hi! > >> > > > > I'm getting a *403: Forbidden* when trying to push the sample: > >> > > > > [image: Inline image 1] > >> > > > > Regards, > >> Christian > >> > > > > On Wed, Jul 25, 2012 at 3:19 PM, <mailto:rmistry@google.com> wrote: > >> > > > > > On 2012/07/25 13:18:48, rmistry wrote: > >> > > >> >> Next step is to commit your sample: > >> >> > >> > > >> > > http://code.google.com/p/****google-api-java-client/wiki/**%3Chttp://code.goo...> > >> > > >> > > > > BecomingAContributor#****Committing_the_code<http://** > > code.google.com/p/google-api-**java-client/wiki/**BecomingAContributor#** > > > Committing_the_code<http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Committing_the_code> > > > > > > > > > >> > Let me know if you run into any permissions issues. > >> > > >> > > >> > > > > http://codereview.appspot.com/****6346073/%253Chttp://** > > > codereview.appspot.com/**6346073/<http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346073/> > > > > > > >> > > >> > > > > > > > http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346...> > >
Sign in to reply to this message.
Hi Ravi, I'm giving up ;( Today I installed Ubuntu on a Virtual Machine. I thought that there could be an issue using a Windows machine for commiting the code. But I'm getting the same error: 404: Not Found This is what I did: 1) hg clone https://code.google.com/p/google-api-java-client.samples/google-api-java-clie... 2) added my example 'fusiontables-cmdline-sample' to the directory 3) hg add fusiontables-cmdline-sample 4) hg commit (using the following commit message) [Issue 544] Fusion Tables API Java Sample http://codereview.appspot.com/6346073/ 5) hg push This is the cmd output for the push: searching for changes http authorization required realm: Google Code hg Repository user: christian@christianjunk.de password: abort: HTTP Error 404: Not Found Perhaps you could do the push for me? Kind regards, Christian On Mon, Jul 30, 2012 at 1:10 PM, <rmistry@google.com> wrote: > Hi Christian, > > Sorry to hear you are having trouble submitting. > Comparing your .hgrc with mine I see a difference in > google-api-java-client.prefix : > > [ui] > username = Ravi Mistry <rmistry@google.com> > > [auth] > google-api-java-client.prefix = > https://google-api-java-**client.googlecode.com/hg/<https://google-api-java-c... > google-api-java-client.**username = rmistry@google.com > google-api-java-client.**password = ... > > > > > On 2012/07/28 18:21:12, Christian Junk wrote: > >> Sorry, wasting your time and causing so much trouble ;( But I nearly >> > spent > >> an hour and I am still not able to push my changes: >> > > I regenerated my password. Now I am getting a 404: Not found (please >> > see > >> attachment) >> > > Here's my .hgrc file >> > > [paths] >> default = https://code.google.com/p/**google-api-java-client.**samples/<https://code.go... >> > > [ui] >> username = Christian Junk <mailto:christian@**christianjunk.de<christian@christianjunk.de> >> > >> schemes = https >> > > [auth] >> google-api-java-client.prefix = >> https://code.google.com/p/**google-api-java-client.**samples/<https://code.go... >> google-api-java-client.**username = mailto:christian@**christianjunk.de<christian@christianjunk.de> >> google-api-java-client.**password = >> > > [web] >> allow_push = * >> push_ssl = True >> > > What am I missing here? >> > > Kind regards, >> Christian >> > > On Fri, Jul 27, 2012 at 9:03 PM, <mailto:rmistry@google.com> wrote: >> > > > I had added mailto:christian@**christianjunk.de<christian@christianjunk.de>as a contributor a >> > while back. > >> > Did you use your >> > > https://code.google.com/****hosting/settings%3Chttps://** > code.google.com/hosting/**settings%3Epassword<https://code.google.com/**hosting/settings%3Chttps://code.google.com/hosting/settings%3Epassword> > > while >> > pushing? >> > >> > >> > On 2012/07/26 19:51:42, Christian Junk wrote: >> > >> >> Hi! >> >> >> > >> > I'm getting a *403: Forbidden* when trying to push the sample: >> >> >> > >> > [image: Inline image 1] >> >> >> > >> > Regards, >> >> Christian >> >> >> > >> > On Wed, Jul 25, 2012 at 3:19 PM, <mailto:rmistry@google.com> wrote: >> >> >> > >> > > On 2012/07/25 13:18:48, rmistry wrote: >> >> > >> >> >> Next step is to commit your sample: >> >> >> >> >> > >> >> > >> > > http://code.google.com/p/******google-api-java-client/wiki/**** > %3Chttp://code.google.com/p/****google-api-java-client/wiki/**<http://code.google.com/p/****google-api-java-client/wiki/**%3Chttp://code.google.com/p/**google-api-java-client/wiki/**> > **> > >> >> > >> >> >> > >> > BecomingAContributor#******Committing_the_code<http://** >> > >> > code.google.com/p/google-api-****java-client/wiki/**** > BecomingAContributor#**<http://code.google.com/p/google-api-**java-client/wiki/**BecomingAContributor#**> > >> > >> > > Committing_the_code<http://**code.google.com/p/google-api-** > java-client/wiki/**BecomingAContributor#**Committing_the_code<http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Committing_the_code> > > > >> > > >> > >> > > >> >> > Let me know if you run into any permissions issues. >> >> > >> >> > >> >> >> > >> > http://codereview.appspot.com/******6346073/%253Chttp://**<http://codereview.... >> > >> > > codereview.appspot.com/****6346073/<http://codereview.appspot.com/**6346073/> > <http://codereview.**appspot.com/**6346073/%3Chttp:** > //codereview.appspot.com/**6346073/<http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346073/> > > > > > > >> > >> >> > >> >> >> > >> > >> > >> > > http://codereview.appspot.com/****6346073/%3Chttp://** > codereview.appspot.com/**6346073/<http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346073/> > > > >> > >> > > > http://codereview.appspot.com/**6346073/<http://codereview.appspot.com/6346073/> >
Sign in to reply to this message.
Submitted in http://code.google.com/p/google-api-java-client/source/detail?r=d37c1d4095f0b... Sorry for the problems you had submitting, and thank you for the contribution. On 2012/08/06 10:22:58, Christian Junk wrote: > Hi Ravi, > > I'm giving up ;( Today I installed Ubuntu on a Virtual Machine. I thought > that there could be an issue using a Windows machine for commiting the code. > > But I'm getting the same error: 404: Not Found > > This is what I did: > > 1) hg clone > https://code.google.com/p/google-api-java-client.samples/google-api-java-clie... > > 2) added my example 'fusiontables-cmdline-sample' to the directory > > 3) hg add fusiontables-cmdline-sample > > 4) hg commit (using the following commit message) > > [Issue 544] Fusion Tables API Java Sample > http://codereview.appspot.com/6346073/ > > 5) hg push > > This is the cmd output for the push: > > searching for changes > http authorization required > realm: Google Code hg Repository > user: mailto:christian@christianjunk.de > password: > abort: HTTP Error 404: Not Found > > Perhaps you could do the push for me? > > Kind regards, > Christian > > > On Mon, Jul 30, 2012 at 1:10 PM, <mailto:rmistry@google.com> wrote: > > > Hi Christian, > > > > Sorry to hear you are having trouble submitting. > > Comparing your .hgrc with mine I see a difference in > > google-api-java-client.prefix : > > > > [ui] > > username = Ravi Mistry <mailto:rmistry@google.com> > > > > [auth] > > google-api-java-client.prefix = > > > https://google-api-java-**client.googlecode.com/hg/%3Chttps://google-api-java...> > > google-api-java-client.**username = mailto:rmistry@google.com > > google-api-java-client.**password = ... > > > > > > > > > > On 2012/07/28 18:21:12, Christian Junk wrote: > > > >> Sorry, wasting your time and causing so much trouble ;( But I nearly > >> > > spent > > > >> an hour and I am still not able to push my changes: > >> > > > > I regenerated my password. Now I am getting a 404: Not found (please > >> > > see > > > >> attachment) > >> > > > > Here's my .hgrc file > >> > > > > [paths] > >> default = > https://code.google.com/p/**google-api-java-client.**samples/%3Chttps://code....> > >> > > > > [ui] > >> username = Christian Junk > <mailto:christian@**christianjunk.de<christian@christianjunk.de> > >> > > >> schemes = https > >> > > > > [auth] > >> google-api-java-client.prefix = > >> > https://code.google.com/p/**google-api-java-client.**samples/%3Chttps://code....> > >> google-api-java-client.**username = > mailto:christian@**christianjunk.de<christian@christianjunk.de> > >> google-api-java-client.**password = > >> > > > > [web] > >> allow_push = * > >> push_ssl = True > >> > > > > What am I missing here? > >> > > > > Kind regards, > >> Christian > >> > > > > On Fri, Jul 27, 2012 at 9:03 PM, <mailto:rmistry@google.com> wrote: > >> > > > > > I had added > mailto:christian@**christianjunk.de<christian@christianjunk.de>as a contributor > a > >> > > while back. > > > >> > Did you use your > >> > > > > https://code.google.com/****hosting/settings%253Chttps://** > > > code.google.com/hosting/**settings%3Epassword<https://code.google.com/**hosting/settings%3Chttps://code.google.com/hosting/settings%3Epassword> > > > > while > >> > pushing? > >> > > >> > > >> > On 2012/07/26 19:51:42, Christian Junk wrote: > >> > > >> >> Hi! > >> >> > >> > > >> > I'm getting a *403: Forbidden* when trying to push the sample: > >> >> > >> > > >> > [image: Inline image 1] > >> >> > >> > > >> > Regards, > >> >> Christian > >> >> > >> > > >> > On Wed, Jul 25, 2012 at 3:19 PM, <mailto:rmistry@google.com> wrote: > >> >> > >> > > >> > > On 2012/07/25 13:18:48, rmistry wrote: > >> >> > > >> >> >> Next step is to commit your sample: > >> >> >> > >> >> > > >> >> > > >> > > > > http://code.google.com/p/******google-api-java-client/wiki/**** > > > %3Chttp://code.google.com/p/****google-api-java-client/wiki/**<http://code.google.com/p/****google-api-java-client/wiki/**%3Chttp://code.google.com/p/**google-api-java-client/wiki/**> > > **> > > > >> >> > > >> >> > >> > > >> > BecomingAContributor#******Committing_the_code<http://** > >> > > >> > > code.google.com/p/google-api-****java-client/wiki/**** > > > BecomingAContributor#**<http://code.google.com/p/google-api-**java-client/wiki/**BecomingAContributor#**> > > > >> > > >> > > > > Committing_the_code<http://**code.google.com/p/google-api-** > > > java-client/wiki/**BecomingAContributor#**Committing_the_code<http://code.google.com/p/google-api-java-client/wiki/BecomingAContributor#Committing_the_code> > > > > > > >> > > > >> > > >> > > > >> >> > Let me know if you run into any permissions issues. > >> >> > > >> >> > > >> >> > >> > > >> > > http://codereview.appspot.com/******6346073/%25253Chttp://**%3Chttp://coderev...> > >> > > >> > > > > codereview.appspot.com/****6346073/<http://codereview.appspot.com/**6346073/> > > <http://codereview.**appspot.com/**6346073/%253Chttp:** > > > //codereview.appspot.com/**6346073/<http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346073/> > > > > > > > > > > >> > > >> >> > > >> >> > >> > > >> > > >> > > >> > > > > http://codereview.appspot.com/****6346073/%253Chttp://** > > > codereview.appspot.com/**6346073/<http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346073/> > > > > > > >> > > >> > > > > > > > http://codereview.appspot.com/**6346073/%3Chttp://codereview.appspot.com/6346...> > >
Sign in to reply to this message.
Since this is submitted, could you please close this issue? (click on edit and then close) Thanks!
Sign in to reply to this message.
Done ;) On Mon, Aug 27, 2012 at 10:33 PM, <rmistry@google.com> wrote: > Since this is submitted, could you please close this issue? (click on > edit and then close) > > Thanks! > > http://codereview.appspot.com/**6346073/<http://codereview.appspot.com/6346073/> >
Sign in to reply to this message.
|
