Issue 6345104: Changed cmsecs to msecs to be consistent with bench.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6345104: Changed cmsecs to msecs to be consistent with bench. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by keyar

Modified:
13 years, 1 month ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Changed cmsecs to msecs to be consistent with bench. We are using wall time and not cpu time and so the proper name for this should probably be outputted.

Patch Set 1 : #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	tools/bench_pictures_main.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages