Issue 6345095: Fix vertex texture fetch.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6345095: Fix vertex texture fetch. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by apatrick1

Modified:
11 years, 9 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix vertex texture fetch. The texture v coordinate was still being flipped. Fixes http://code.google.com/p/chromium/issues/detail?id=136650. Committed: https://code.google.com/p/angleproject/source/detail?r=1214

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -22 lines)			Patch
	M	src/compiler/OutputHLSL.cpp	View		6 chunks	+8 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

11 years, 9 months ago (2012-07-12 01:31:42 UTC) #3

LGTM. Nice work tracking this down.

Could you link to http://code.google.com/p/chromium/issues/detail?id=136650 in
the description?

Expand All Messages | Collapse All Messages