Issue 6345092: Add a .desktop file for ibus-setup-pinyin

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6345092: Add a .desktop file for ibus-setup-pinyin (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by TiagoMatos

Modified:
11 years, 9 months ago

Reviewers:
shawn.p.huang

Base URL:
git://github.com/ibus/ibus-pinyin.git@master

Visibility:
Public.

More Reviews

Description

Add a .desktop file for ibus-setup-pinyin This allows it to be launched with startup notification and be tracked as a proper application in GNOME 3. BUG=http://code.google.com/p/ibus/issues/detail?id=1483 TEST=

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added a .desktop file for bopomofo #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -0 lines)			Patch
M	data/.gitignore	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	data/Makefile.am	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
A	data/ibus-setup-bopomofo.desktop.in.in	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
A	data/ibus-setup-pinyin.desktop.in.in	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	po/POTFILES.in	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	po/POTFILES.skip	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/6345092/diff/1/data/ibus-setup-pinyin.desktop.in.in File data/ibus-setup-pinyin.desktop.in.in (right): https://codereview.appspot.com/6345092/diff/1/data/ibus-setup-pinyin.desktop.in.in#newcode1 data/ibus-setup-pinyin.desktop.in.in:1: [Desktop Entry] Could you please add another desktop file ...

11 years, 9 months ago (2012-07-12 14:46:33 UTC) #2

TiagoMatos

Hmm, I guess that rietveld didn't send updates when I uploaded the new patch. Make ...

11 years, 9 months ago (2012-07-12 18:07:59 UTC) #3

Peng

11 years, 9 months ago (2012-07-12 19:01:29 UTC) #4

On 2012/07/12 18:07:59, TiagoMatos wrote:
> Hmm, I guess that rietveld didn't send updates when I uploaded the new patch.
> Make it do so now.

lgtm. CL has been landed. please close it.

Expand All Messages | Collapse All Messages