Allow specific files and multiple inputs for picture testing tools.

Allow specific files and multiple inputs for picture testing tools.

Changed the render_pictures, bench_pictures and test_pictures.py so that multiple inputs can be given. Furthermore, specific files can also be specified.

Unit tests have also been added for picture_utils.cpp.

Committed http://code.google.com/p/skia/source/detail?r=4486
Committed http://code.google.com/p/skia/source/detail?r=4488

[keyar, 2012-06-29 20:39:23]

Please review.

[reed1, 2012-07-02 13:21:18]

can we try adding some unittests for these tool utils? This latest function
seems a great candidate.

[keyar, 2012-07-03 20:39:25]

Tests now exist for make_filepath and get_basename.

[reed1, 2012-07-09 13:59:19]

I like the centralization of the utility, just have some comments on its
interface/impl.

https://codereview.appspot.com/6345054/diff/12001/tools/picture_utils.cpp
File tools/picture_utils.cpp (right):

https://codereview.appspot.com/6345054/diff/12001/tools/picture_utils.cpp#new...
tools/picture_utils.cpp:34: 
Nearly every edit to a string can involve new/delete, as we allocate space for
the answer.

Since this function is basically just extracting a subset from path, can the
impl just find the start/end of that substring, and then copy it into basename
in a single call?

https://codereview.appspot.com/6345054/diff/12001/tools/picture_utils.h
File tools/picture_utils.h (right):

https://codereview.appspot.com/6345054/diff/12001/tools/picture_utils.h#newco...
tools/picture_utils.h:25: // only)
Can this just return const char*, since it will be (by definition) at the end of
the string?

[keyar, 2012-07-09 17:21:20]

get_basename now copies in part of the string instead of repeatedly removing
parts of the string. The only file changed is picture_utils.cpp, so sorry about
the patch set claiming every file was changed. I just switched over to using
git.

https://codereview.appspot.com/6345054/diff/12001/tools/picture_utils.h
File tools/picture_utils.h (right):

https://codereview.appspot.com/6345054/diff/12001/tools/picture_utils.h#newco...
tools/picture_utils.h:25: // only)
On 2012/07/09 13:59:19, reed1 wrote:
> Can this just return const char*, since it will be (by definition) at the end
of
> the string?

We can do this if we are ok with directories having the last slash as a part of
their name (i.e. if the path is /path/dir/ it would return dir/).

[keyar, 2012-07-09 17:21:42]

On 2012/07/09 17:21:20, keyar wrote:
> get_basename now copies in part of the string instead of repeatedly removing
> parts of the string. The only file changed is picture_utils.cpp, so sorry
about
> the patch set claiming every file was changed. I just switched over to using
> git.
> 
> https://codereview.appspot.com/6345054/diff/12001/tools/picture_utils.h
> File tools/picture_utils.h (right):
> 
>
https://codereview.appspot.com/6345054/diff/12001/tools/picture_utils.h#newco...
> tools/picture_utils.h:25: // only)
> On 2012/07/09 13:59:19, reed1 wrote:
> > Can this just return const char*, since it will be (by definition) at the
end
> of
> > the string?
> 
> We can do this if we are ok with directories having the last slash as a part
of
> their name (i.e. if the path is /path/dir/ it would return dir/).

Also, tests/PictureUtilsTest.cpp

[reed1, 2012-07-09 17:34:57]

lgtm