Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6515)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6345045: Add a symbol property in IBusEngineDesc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by fujiwara
Modified:
11 years, 9 months ago
Reviewers:
shawn.p.huang
CC:
shawn.p.huang_gmail.com
Base URL:
git://github.com/ibus/ibus-pinyin.git@master
Visibility:
Public.

Description

Add a symbol property in IBusEngineDesc. BUG=http://code.google.com/p/ibus/issues/detail?id=1473 TEST=Manually

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Fixed a typo. #

Total comments: 2

Patch Set 4 : Updated with the message #4 #

Total comments: 1

Patch Set 5 : Updated with message #6. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M src/PYMain.cc View 1 2 3 4 1 chunk +22 lines, -18 lines 0 comments Download
M src/pinyin.xml.in.in View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9
fujiwara
11 years, 10 months ago (2012-06-27 10:23:50 UTC) #1
Peng
https://codereview.appspot.com/6345045/diff/1/configure.ac File configure.ac (right): https://codereview.appspot.com/6345045/diff/1/configure.ac#newcode199 configure.ac:199: AC_ARG_WITH(engine-symbol, I think the latest ibus already has symbol ...
11 years, 10 months ago (2012-06-27 13:22:56 UTC) #2
fujiwara
On 2012/06/27 13:22:56, Peng wrote: > https://codereview.appspot.com/6345045/diff/1/configure.ac > File configure.ac (right): > > https://codereview.appspot.com/6345045/diff/1/configure.ac#newcode199 > ...
11 years, 10 months ago (2012-06-28 03:54:57 UTC) #3
Peng
https://codereview.appspot.com/6345045/diff/8001/configure.ac File configure.ac (right): https://codereview.appspot.com/6345045/diff/8001/configure.ac#newcode199 configure.ac:199: AC_ARG_WITH(engine-symbol, I don't think it is necessary to make ...
11 years, 9 months ago (2012-07-10 18:20:29 UTC) #4
fujiwara
On 2012/07/10 18:20:29, Peng wrote: > https://codereview.appspot.com/6345045/diff/8001/configure.ac > File configure.ac (right): > > https://codereview.appspot.com/6345045/diff/8001/configure.ac#newcode199 > ...
11 years, 9 months ago (2012-07-11 06:00:28 UTC) #5
Peng
https://codereview.appspot.com/6345045/diff/9004/src/PYMain.cc File src/PYMain.cc (right): https://codereview.appspot.com/6345045/diff/9004/src/PYMain.cc#newcode112 src/PYMain.cc:112: "symbol", "中", Maybe use some thing like "\u4e2d"?
11 years, 9 months ago (2012-07-11 18:32:23 UTC) #6
fujiwara
On 2012/07/11 18:32:23, Peng wrote: > https://codereview.appspot.com/6345045/diff/9004/src/PYMain.cc > File src/PYMain.cc (right): > > https://codereview.appspot.com/6345045/diff/9004/src/PYMain.cc#newcode112 > ...
11 years, 9 months ago (2012-07-13 06:06:09 UTC) #7
Peng
On 2012/07/13 06:06:09, fujiwara wrote: > On 2012/07/11 18:32:23, Peng wrote: > > https://codereview.appspot.com/6345045/diff/9004/src/PYMain.cc > ...
11 years, 9 months ago (2012-07-13 13:56:24 UTC) #8
Peng
11 years, 9 months ago (2012-07-16 14:58:08 UTC) #9 
On 2012/07/13 13:56:24, Peng wrote:
> On 2012/07/13 06:06:09, fujiwara wrote:
> > On 2012/07/11 18:32:23, Peng wrote:
> > > https://codereview.appspot.com/6345045/diff/9004/src/PYMain.cc
> > > File src/PYMain.cc (right):
> > > 
> > > https://codereview.appspot.com/6345045/diff/9004/src/PYMain.cc#newcode112
> > > src/PYMain.cc:112: "symbol", "中",
> > > Maybe use some thing like "\u4e2d"?
> > 
> > I don't mind who fix this.
> lgtm
landed it. please close it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b