Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3726)

Issue 6344096: gyp_skia: Fix module search path. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by digit1
Modified:
12 years, 3 months ago
Reviewers:
DerekS, caryclark1, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

gyp_skia: Fix module search path. gyp_skia should prepend the local gyp source path to the python module search path, instead of appending it. Otherwise, if a 'gyp' module is locally installed on the machine, it will be read instead of the current version in the Skia tree. This breaks the Android build when the installed 'gyp' module doesn't support the "make-android" generator. Committed: https://code.google.com/p/skia/source/detail?r=4832

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gyp_skia View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2
digit1
ping?
12 years, 4 months ago (2012-07-12 09:42:34 UTC) #1
caryclark1
12 years, 4 months ago (2012-07-12 11:20:23 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b