Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(239)

Issue 6344091: Added conical gradient to gm gradients test, and added two variants of that test, one with perspect… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by rileya
Modified:
11 years, 12 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added conical gradient to gm gradients test, and added two variants of that test, one with perspective applied to the local matrices of the gradients and the other with perspective applied to the overall view matrix. Will require GM rebaselining. Committed: https://code.google.com/p/skia/source/detail?r=4468

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -2 lines) Patch
M gm/gradients.cpp View 4 chunks +100 lines, -2 lines 0 comments Download

Messages

Total messages: 2
rileya
Is there any additional setup required when adding/changing gm tests?
11 years, 12 months ago (2012-07-09 14:12:19 UTC) #1
bsalomon
11 years, 12 months ago (2012-07-09 14:39:46 UTC) #2
LGTM

On 2012/07/09 14:12:19, rileya wrote:
> Is there any additional setup required when adding/changing gm tests?

The process is to checkin, which turns gm red, and then rebaseline. There are
some tools to assist with this. I'll walk you through it once you're checked in
and the bots have completed. We should also get images checked in for your new
tests.

A semi-standard practice is to add a line to your commit comment that the change
is expected to require GM rebaselining.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b