Issue 6344069: Provide static global initializers for SkColorTable and SkComposeShader.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6344069: Provide static global initializers for SkColorTable and SkComposeShader. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by Leon

Modified:
12 years, 5 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Provide static global initializers for SkColorTable and SkComposeShader. This makes some GMs which were broken on Android work. Reenable them on Android. Also fix a typo in gmmain. Committed: https://code.google.com/p/skia/source/detail?r=4426

Patch Set 1 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -13 lines)			Patch
M	gm/bitmapfilters.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	gm/composeshader.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	gm/gmmain.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

DerekS

12 years, 5 months ago (2012-07-02 19:03:30 UTC) #2

On 2012/07/02 18:42:43, scroggo-work wrote:

lgtm. nice catch!

Expand All Messages | Collapse All Messages