s3: fix regions that require lowercase buckets.

s3/s3.go

 //
 // goamz - Go packages to interact with the Amazon Web Services.
 //
 //   https://wiki.ubuntu.com/goamz
 //
 // Copyright (c) 2011 Canonical Ltd.
 //
 // Written by Gustavo Niemeyer <gustavo.niemeyer@canonical.com>
 //
 
@@ skipping 36 matching lines @@
         DisplayName string
 }
 
 // New creates a new S3.
 func New(auth aws.Auth, region aws.Region) *S3 {
         return &S3{auth, region, 0}
 }
 
 // Bucket returns a Bucket with the given name.
 func (s3 *S3) Bucket(name string) *Bucket {
-        // Some regions outside the US do not permit upper case bucket names, as
-        // they cannot be legal domain name components.
-        return &Bucket{s3, strings.ToLower(name)}
+        if s3.Region.S3BucketEndpoint != "" || s3.Region.S3LowercaseBucket {
+                name = strings.ToLower(name)
+        }
+        return &Bucket{s3, name}
 }
 
 var createBucketConfiguration = `<CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">·
   <LocationConstraint>%s</LocationConstraint>·
 </CreateBucketConfiguration>`
 
 // locationConstraint returns an io.Reader specifying a LocationConstraint if·
 // required for the region.
 //
 // See http://goo.gl/bh9Kq for more details.
 func (s3 *S3) locationConstraint() io.Reader {
         constraint := ""
-        if s3.Region.Name != aws.USEast.Name {
-                // CreateBucketConfiguration is manditory for non us-east-1, but
-                // forbidden for us-east-1.
+        if s3.Region.S3LocationConstraint {
                 constraint = fmt.Sprintf(createBucketConfiguration, s3.Region.Name)
         }
         return strings.NewReader(constraint)
 }
 
 type ACL string
 
 const (
         Private           = ACL("private")
         PublicRead        = ACL("public-read")
@@ skipping 403 matching lines @@
         r.Body.Close()
         err.StatusCode = r.StatusCode
         if err.Message == "" {
                 err.Message = r.Status
         }
         if debug {
                 log.Printf("err: %#v\n", err)
         }
         return &err
 }