Issue 6343069: Add optional logging to html sanitizer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6343069: Add optional logging to html sanitizer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Jasvir

Modified:
13 years, 8 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Adds an optional logger which gets called everytime tags, attributes or values are rewritten or elided by the sanitizer @4960

Patch Set 2 : Add optional logging to html sanitizer #

Total comments: 1

Patch Set 3 : Add optional logging to html sanitizer #

Total comments: 1

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+112 lines, -8 lines)			Patch
	M	src/com/google/caja/plugin/html-sanitizer.js	View	1 2	8 chunks	+66 lines, -8 lines	1 comment	Download
	M	tests/com/google/caja/plugin/html-sanitizer-test.js	View	1 2	3 chunks	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

felix8a

one suggestion, but lgtm http://codereview.appspot.com/6343069/diff/3001/src/com/google/caja/plugin/html-sanitizer.js File src/com/google/caja/plugin/html-sanitizer.js (right): http://codereview.appspot.com/6343069/diff/3001/src/com/google/caja/plugin/html-sanitizer.js#newcode744 src/com/google/caja/plugin/html-sanitizer.js:744: function log(opt_logger, type, tagName, attribName, ...

13 years, 9 months ago (2012-07-03 06:30:46 UTC) #2

felix8a

13 years, 9 months ago (2012-07-03 14:33:08 UTC) #4

lgtm

http://codereview.appspot.com/6343069/diff/9001/src/com/google/caja/plugin/ht...
File src/com/google/caja/plugin/html-sanitizer.js (right):

http://codereview.appspot.com/6343069/diff/9001/src/com/google/caja/plugin/ht...
src/com/google/caja/plugin/html-sanitizer.js:751: if (oldValue !== newValue &&
'function' === typeof opt_logger) {
remove 'function' === typeof opt_logger

Expand All Messages | Collapse All Messages