Separate target architecture type and width into separate variables.

Separate target architecture type and width into separate variables.

Also add support for building mac in 64 bit mode.
Committed: https://code.google.com/p/skia/source/detail?r=4385

[reed1, 2012-06-28 14:17:04]

do we need the word target_ in those names?

[DerekS, 2012-06-28 14:19:15]

On 2012/06/28 14:17:04, reed1 wrote:
> do we need the word target_ in those names?

short answer...nope.  Longer answer... it depends on if we will ever care to
specify what the host architecture is.

[DerekS, 2012-06-28 14:28:54]

On 2012/06/28 14:19:15, DerekS wrote:
> On 2012/06/28 14:17:04, reed1 wrote:
> > do we need the word target_ in those names?
> 
> short answer...nope.  Longer answer... it depends on if we will ever care to
> specify what the host architecture is.

I removed the _target in patch set 2

[reed1, 2012-06-28 14:29:50]

isn't the host arch inferable (as we do today)?

[DerekS, 2012-06-28 14:37:14]

Yes, which is why I removed it in patch set 2.


On Thu, Jun 28, 2012 at 10:29 AM, <reed@google.com> wrote:

> isn't the host arch inferable (as we do today)?
>
>
https://codereview.appspot.**com/6343050/<https://codereview.appspot.com/6343...
>

[epoger, 2012-06-28 14:53:52]

LGTM with one suggestion

https://codereview.appspot.com/6343050/diff/5001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.appspot.com/6343050/diff/5001/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:121: }],
maybe add this below?

       ['skia_arch_width == "32"', {
         'xcode_settings': {
           'ARCHS': 'i386',
         },
       }],

[DerekS, 2012-06-28 15:46:25]

On 2012/06/28 14:53:52, epoger wrote:
> LGTM with one suggestion
> 
> https://codereview.appspot.com/6343050/diff/5001/gyp/common_conditions.gypi
> File gyp/common_conditions.gypi (right):
> 
>
https://codereview.appspot.com/6343050/diff/5001/gyp/common_conditions.gypi#n...
> gyp/common_conditions.gypi:121: }],
> maybe add this below?
> 
>        ['skia_arch_width == "32"', {
>          'xcode_settings': {
>            'ARCHS': 'i386',
>          },
>        }],

patch set 3 fixes the mac build, implements the suggestion, and prints an error
if any width other than 64 or 32 is given.

[epoger, 2012-06-28 15:48:08]

LGTM