Issue 6342052: write my own os.path.abspath() to work around Win path-length limits

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6342052: write my own os.path.abspath() to work around Win path-length limits (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by epoger

Modified:
12 years, 6 months ago

Reviewers:
bungeman

CC:
skia-review_googlegroups.com, EricB

Base URL:
http://skia.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

write my own os.path.abspath() to work around Win path-length limits BUG=https://code.google.com/p/skia/issues/detail?id=674 Committed: https://code.google.com/p/skia/source/detail?r=4357

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -2 lines)			Patch
	M	buildbot/slave/skia_slave_scripts/upload_to_bucket.py	View		1 chunk	+20 lines, -1 line	0 comments	Download
	M	trunk/bench/bench_graph_svg.py	View		2 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

epoger

This one actually works... see http://c128.i.corp.google.com:8041/builders/Skia_Shuttle_Win7_Intel_Float_Release/builds/34 , where I manually patched this change into the ...

12 years, 6 months ago (2012-06-26 19:48:03 UTC) #1

bungeman

12 years, 6 months ago (2012-06-26 21:52:50 UTC) #2

On 2012/06/26 19:48:03, epoger wrote:
> This one actually works... see
>
http://c128.i.corp.google.com:8041/builders/Skia_Shuttle_Win7_Intel_Float_Rel...
> , where I manually patched this change into the new Windows build slave.

LGTM

Expand All Messages | Collapse All Messages