src/pkg/runtime/iface.c - Issue 6337058: code review 6337058: cmd/gc: cache itab lookup in convT2I.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/runtime/iface.c

Issue 6337058: code review 6337058: cmd/gc: cache itab lookup in convT2I. (Closed)

Patch Set: diff -r c533f48701cb https://go.googlecode.com/hg/ Created 12 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/runtime/iface.c

===================================================================

--- a/src/pkg/runtime/iface.c

+++ b/src/pkg/runtime/iface.c

@@ -183,19 +183,25 @@

alg->copy(size, dst, *src);

}

-// func convT2I(typ *byte, typ2 *byte, elem any) (ret any)

+// func convT2I(typ *byte, typ2 *byte, cache **byte, elem any) (ret any)

#pragma textflag 7

void

-runtime·convT2I(Type *t, InterfaceType *inter, ...)

+runtime·convT2I(Type *t, InterfaceType *inter, Itab **cache, ...)

{

byte *elem;

Iface *ret;

+ Itab *tab;

int32 wid;

- elem = (byte*)(&inter+1);

+ elem = (byte*)(&cache+1);

wid = t->size;

ret = (Iface*)(elem + ROUND(wid, Structrnd));

- ret->tab = itab(inter, t, 0);

+ tab = runtime·atomicloadp(cache);

+ if(!tab) {

+ tab = itab(inter, t, 0);

+ runtime·atomicstorep(cache, tab);

+ }

+ ret->tab = tab;

copyin(t, elem, &ret->data);

}

« no previous file with comments | « src/cmd/gc/walk.c ('k') | src/pkg/runtime/iface_test.go » ('j') | no next file with comments »