src/cmd/gc/builtin.c - Issue 6337058: code review 6337058: cmd/gc: cache itab lookup in convT2I.

Delta Between Two Patch Sets: src/cmd/gc/builtin.c

Issue 6337058: code review 6337058: cmd/gc: cache itab lookup in convT2I. (Closed)

Left Patch Set: Created 12 years, 9 months ago

Right Patch Set: diff -r c533f48701cb https://go.googlecode.com/hg/ Created 12 years, 9 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Right: Side by side diff | Download

LEFT	RIGHT
(no file at all)
1 char *runtimeimport =	1 char *runtimeimport =

2 "package runtime\n"	2 "package runtime\n"

3 "import runtime \"runtime\"\n"	3 "import runtime \"runtime\"\n"

4 "func @\"\".new(@\"\".typ byte) (? any)\n"	4 "func @\"\".new(@\"\".typ byte) (? any)\n"

5 "func @\"\".panicindex()\n"	5 "func @\"\".panicindex()\n"

6 "func @\"\".panicslice()\n"	6 "func @\"\".panicslice()\n"

7 "func @\"\".throwreturn()\n"	7 "func @\"\".throwreturn()\n"

8 "func @\"\".throwinit()\n"	8 "func @\"\".throwinit()\n"

9 "func @\"\".panicwrap(? string, ? string, ? string)\n"	9 "func @\"\".panicwrap(? string, ? string, ? string)\n"

10 "func @\"\".panic(? interface {})\n"	10 "func @\"\".panic(? interface {})\n"

(...skipping 23 matching lines...) Expand all Loading...
34 "func @\"\".slicerunetostring(? []rune) (? string)\n"	34 "func @\"\".slicerunetostring(? []rune) (? string)\n"

35 "func @\"\".stringtoslicebyte(? string) (? []byte)\n"	35 "func @\"\".stringtoslicebyte(? string) (? []byte)\n"

36 "func @\"\".stringtoslicerune(? string) (? []rune)\n"	36 "func @\"\".stringtoslicerune(? string) (? []rune)\n"

37 "func @\"\".stringiter(? string, ? int) (? int)\n"	37 "func @\"\".stringiter(? string, ? int) (? int)\n"

38 "func @\"\".stringiter2(? string, ? int) (@\"\".retk int, @\"\".retv run e)\n"	38 "func @\"\".stringiter2(? string, ? int) (@\"\".retk int, @\"\".retv run e)\n"

39 "func @\"\".copy(@\"\".to any, @\"\".fr any, @\"\".wid uint32) (? int)\n "	39 "func @\"\".copy(@\"\".to any, @\"\".fr any, @\"\".wid uint32) (? int)\n "

40 "func @\"\".slicestringcopy(@\"\".to any, @\"\".fr any) (? int)\n"	40 "func @\"\".slicestringcopy(@\"\".to any, @\"\".fr any) (? int)\n"

41 "func @\"\".convI2E(@\"\".elem any) (@\"\".ret any)\n"	41 "func @\"\".convI2E(@\"\".elem any) (@\"\".ret any)\n"

42 "func @\"\".convI2I(@\"\".typ *byte, @\"\".elem any) (@\"\".ret any)\n"	42 "func @\"\".convI2I(@\"\".typ *byte, @\"\".elem any) (@\"\".ret any)\n"

43 "func @\"\".convT2E(@\"\".typ *byte, @\"\".elem any) (@\"\".ret any)\n"	43 "func @\"\".convT2E(@\"\".typ *byte, @\"\".elem any) (@\"\".ret any)\n"

44 » "func @\"\".convT2I(@\"\".typ byte, @\"\".typ2 byte, @\"\".elem any) ( @\"\".ret any)\n"	44 » "func @\"\".convT2I(@\"\".typ byte, @\"\".typ2 byte, @\"\".cache **byt e, @\"\".elem any) (@\"\".ret any)\n"

45 "func @\"\".assertE2E(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"	45 "func @\"\".assertE2E(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"

46 "func @\"\".assertE2E2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"	46 "func @\"\".assertE2E2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"

47 "func @\"\".assertE2I(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"	47 "func @\"\".assertE2I(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"

48 "func @\"\".assertE2I2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"	48 "func @\"\".assertE2I2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"

49 "func @\"\".assertE2T(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"	49 "func @\"\".assertE2T(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"

50 "func @\"\".assertE2T2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"	50 "func @\"\".assertE2T2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"

51 "func @\"\".assertI2E(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"	51 "func @\"\".assertI2E(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"

52 "func @\"\".assertI2E2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"	52 "func @\"\".assertI2E2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"

53 "func @\"\".assertI2I(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"	53 "func @\"\".assertI2I(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any)\ n"

54 "func @\"\".assertI2I2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"	54 "func @\"\".assertI2I2(@\"\".typ *byte, @\"\".iface any) (@\"\".ret any, @\"\".ok bool)\n"

(...skipping 51 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
106 "$$\n";	106 "$$\n";

107 char *unsafeimport =	107 char *unsafeimport =

108 "package unsafe\n"	108 "package unsafe\n"

109 "import runtime \"runtime\"\n"	109 "import runtime \"runtime\"\n"

110 "type @\"\".Pointer uintptr\n"	110 "type @\"\".Pointer uintptr\n"

111 "func @\"\".Offsetof(? any) (? uintptr)\n"	111 "func @\"\".Offsetof(? any) (? uintptr)\n"

112 "func @\"\".Sizeof(? any) (? uintptr)\n"	112 "func @\"\".Sizeof(? any) (? uintptr)\n"

113 "func @\"\".Alignof(? any) (? uintptr)\n"	113 "func @\"\".Alignof(? any) (? uintptr)\n"

114 "\n"	114 "\n"

115 "$$\n";	115 "$$\n";

LEFT	RIGHT