Issue 6334050: Fix setFileOffset type to remove warnings.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6334050: Fix setFileOffset type to remove warnings. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Steve VanDeBogart

Modified:
11 years, 11 months ago

Reviewers:
caryclark1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix setFileOffset type to remove warnings. Committed: https://code.google.com/p/skia/source/detail?r=4585

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -13 lines)			Patch
M	src/pdf/SkPDFCatalog.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pdf/SkPDFCatalog.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/pdf/SkPDFDocument.cpp	View	2 chunks	+6 lines, -9 lines	0 comments	Download
M	src/pdf/SkPDFPage.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Steve VanDeBogart

Cary, does this also fix the warnings you fixed in r4178? This change gets rid ...

12 years ago (2012-06-25 17:37:09 UTC) #1

Steve VanDeBogart

On 2012/06/25 17:37:09, Steve VanDeBogart wrote: > Cary, does this also fix the warnings you ...

11 years, 11 months ago (2012-07-12 19:57:12 UTC) #2

caryclark1

Steve, my sincere apologies. I misread the original message and did not realize that this ...

11 years, 11 months ago (2012-07-12 20:08:59 UTC) #3

Steve VanDeBogart

11 years, 11 months ago (2012-07-12 20:15:45 UTC) #4

On 2012/07/12 20:08:59, caryclark1 wrote:
> Steve, my sincere apologies. I misread the original message and did not
realize
> that this was a code review. I applied the patch locally and verified that it
> does not report any warnings.

No worries, just a cleanup. I was out all last week so I didn't follow up until
now. Thanks.

Expand All Messages | Collapse All Messages