Fix SkGPipe drawing, and turn it on by default.

Fix SkGPipe drawing, and turn it on by default.

A recent change broke SkGPipe. Fix it, and turn on pipe drawing
in GM by default so we will catch these in the future.

We already had a bug where SkGPipeWriter had to use its Cross Process
flag to work, so for a quick fix, force the reader to use the Cross
Process flag as well. The bug to allow both cross and non cross process
is http://code.google.com/p/skia/issues/detail?id=663

[Leon, 2012-06-27 19:20:20]

I was not sure how to update the comment, but patch set 2 fixes the cross
process issue.

[reed1, 2012-06-27 19:37:27]

lgtm w/ nits

https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (right):

https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp#new...
src/pipe/SkGPipeRead.cpp:71: fFlags = flags;
nit: if (fFlags != flags) { ... updateReader(); }

https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp#new...
src/pipe/SkGPipeRead.cpp:125: }
use SkToBool(fFlags & ...) to convert to bool w/o warning (in case your flag is
no longer the low-bit)

[Leon, 2012-06-28 15:37:07]

https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp
File src/pipe/SkGPipeRead.cpp (right):

https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp#new...
src/pipe/SkGPipeRead.cpp:71: fFlags = flags;
On 2012/06/27 19:37:27, reed1 wrote:
> nit: if (fFlags != flags) { ... updateReader(); }

Done.

https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp#new...
src/pipe/SkGPipeRead.cpp:125: }
On 2012/06/27 19:37:27, reed1 wrote:
> use SkToBool(fFlags & ...) to convert to bool w/o warning (in case your flag
is
> no longer the low-bit)

Done.

[reed1, 2012-06-28 15:40:36]

lgtm