Issue 6333071: Fix SkGPipe drawing, and turn it on by default.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6333071: Fix SkGPipe drawing, and turn it on by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by Leon

Modified:
12 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix SkGPipe drawing, and turn it on by default. A recent change broke SkGPipe. Fix it, and turn on pipe drawing in GM by default so we will catch these in the future. We already had a bug where SkGPipeWriter had to use its Cross Process flag to work, so for a quick fix, force the reader to use the Cross Process flag as well. The bug to allow both cross and non cross process is http://code.google.com/p/skia/issues/detail?id=663

Patch Set 1 #

Patch Set 2 : Fixes the bug mentioned in the last patch set. Allows pipe to be run in cross process mode and not … #

Total comments: 4

Patch Set 3 : Fix nits #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -97 lines)			Patch
M	gm/gmmain.cpp	View	1 2	7 chunks	+59 lines, -28 lines	0 comments	Download
M	include/pipe/SkGPipe.h	View	1	2 chunks	+12 lines, -2 lines	0 comments	Download
M	src/pipe/SkGPipePriv.h	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/pipe/SkGPipeRead.cpp	View	1 2	9 chunks	+48 lines, -11 lines	0 comments	Download
M	src/pipe/SkGPipeWrite.cpp	View	1	18 chunks	+119 lines, -56 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Leon

I was not sure how to update the comment, but patch set 2 fixes the ...

12 years ago (2012-06-27 19:20:20 UTC) #2

reed1

lgtm w/ nits https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp File src/pipe/SkGPipeRead.cpp (right): https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp#newcode71 src/pipe/SkGPipeRead.cpp:71: fFlags = flags; nit: if (fFlags ...

12 years ago (2012-06-27 19:37:27 UTC) #3

Leon

https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp File src/pipe/SkGPipeRead.cpp (right): https://codereview.appspot.com/6333071/diff/3001/src/pipe/SkGPipeRead.cpp#newcode71 src/pipe/SkGPipeRead.cpp:71: fFlags = flags; On 2012/06/27 19:37:27, reed1 wrote: > ...

12 years ago (2012-06-28 15:37:07 UTC) #4

lgtm

Expand All Messages | Collapse All Messages