Cleanup flattening code to properly serialize lighting image filters.

Cleanup flattening code to properly serialize lighting image filters.
Committed: https://code.google.com/p/skia/source/detail?r=4340

[DerekS, 2012-06-26 14:22:57]

I needed to update this code in order for it to work with my upcoming changes to
flattenables as well as to make the SkPipe work for Leon.

[Leon, 2012-06-26 14:26:11]

lgtm

[Stephen White, 2012-06-26 15:30:22]

On 2012/06/26 14:22:57, DerekS wrote:
> I needed to update this code in order for it to work with my upcoming changes
to
> flattenables as well as to make the SkPipe work for Leon.

Thanks for cleaning this up.  Could you let me know how to test this in the
future?  It seemed to be working in SampleApp and gm, but maybe I was testing it
wrong?

[DerekS, 2012-06-26 15:36:49]

On 2012/06/26 15:30:22, Stephen White wrote:
> On 2012/06/26 14:22:57, DerekS wrote:
> > I needed to update this code in order for it to work with my upcoming
changes
> to
> > flattenables as well as to make the SkPipe work for Leon.
> 
> Thanks for cleaning this up.  Could you let me know how to test this in the
> future?  It seemed to be working in SampleApp and gm, but maybe I was testing
it
> wrong?

Unfortunately, I don't think you could have caught this yet without a bunch of
extra work.  

When I introduce the persistent file format in a couple of weeks it will catch
it, which is how I noticed the error.  However, Leon also noticed it because
when you run the sample app or GM through an SkPipe (which forces cross-process
mode and inlining of factory names) it appears.  Leon, since my code is not yet
available is there any way to run the gm with the SkPipe?

[Leon, 2012-06-26 15:46:33]

Yes, by adding --pipe to the command line for gm. That said, I have a
change<https://codereview.appspot.com/6333071/>out for review that
will turn the pipe on by default.

On Tue, Jun 26, 2012 at 11:36 AM, <djsollen@google.com> wrote:

> On 2012/06/26 15:30:22, Stephen White wrote:
>
>> On 2012/06/26 14:22:57, DerekS wrote:
>> > I needed to update this code in order for it to work with my
>>
> upcoming changes
>
>> to
>> > flattenables as well as to make the SkPipe work for Leon.
>>
>
>  Thanks for cleaning this up.  Could you let me know how to test this
>>
> in the
>
>> future?  It seemed to be working in SampleApp and gm, but maybe I was
>>
> testing it
>
>> wrong?
>>
>
> Unfortunately, I don't think you could have caught this yet without a
> bunch of extra work.
>
> When I introduce the persistent file format in a couple of weeks it will
> catch it, which is how I noticed the error.  However, Leon also noticed
> it because when you run the sample app or GM through an SkPipe (which
> forces cross-process mode and inlining of factory names) it appears.
> Leon, since my code is not yet available is there any way to run the gm
> with the SkPipe?
>
>
http://codereview.appspot.com/**6333070/<http://codereview.appspot.com/6333070/>
>



-- 
Leon Scroggins III
scroggo@google.com