Issue 6333046: Implemented conditional processing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6333046: Implemented conditional processing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Alok Priyadarshi

Modified:
11 years, 10 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Implemented conditional processing. Committed: https://code.google.com/p/angleproject/source/detail?r=1168

Patch Set 7 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1263 lines, -100 lines)			Patch
M	src/compiler/preprocessor/new/Diagnostics.h	View		3 chunks	+8 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.h	View		2 chunks	+24 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.cpp	View	1 2 3 4	11 chunks	+432 lines, -89 lines	0 comments	Download
M	src/compiler/preprocessor/new/ExpressionParser.cpp	View	1 2 3 4	6 chunks	+18 lines, -7 lines	0 comments	Download
M	src/compiler/preprocessor/new/ExpressionParser.y	View	1 2 3 4	5 chunks	+15 lines, -4 lines	0 comments	Download
M	tests/build_tests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/preprocessor_tests/if_test.cpp	View	1 2 3 4 5 6	1 chunk	+765 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kbr1

LGTM overall. Very nice. Couple of minor comments and suggestions. http://codereview.appspot.com/6333046/diff/7006/tests/preprocessor_tests/if_test.cpp File tests/preprocessor_tests/if_test.cpp (right): http://codereview.appspot.com/6333046/diff/7006/tests/preprocessor_tests/if_test.cpp#newcode209 ...

11 years, 10 months ago (2012-06-26 02:33:38 UTC) #2

Alok Priyadarshi

11 years, 10 months ago (2012-06-26 04:37:20 UTC) #3

http://codereview.appspot.com/6333046/diff/7006/tests/preprocessor_tests/if_t...
File tests/preprocessor_tests/if_test.cpp (right):

http://codereview.appspot.com/6333046/diff/7006/tests/preprocessor_tests/if_t...
tests/preprocessor_tests/if_test.cpp:209: "#if 1\n"
On 2012/06/26 02:33:38, kbr1 wrote:
> Is it worth testing nesting one more level deep? If not -- if it won't add
code
> coverage -- that's fine.

It will not increase coverage with the way things are implemented right now.

http://codereview.appspot.com/6333046/diff/7006/tests/preprocessor_tests/if_t...
tests/preprocessor_tests/if_test.cpp:527: "foo !@#$%^&* .1bar\n"
On 2012/06/26 02:33:38, kbr1 wrote:
> How about testing broken preprocessor directives inside an excluded block?

Yes good idea. This will increase coverage. DONE.

Expand All Messages | Collapse All Messages