Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(609)

Issue 6331062: code review 6331062: fmt: set p.field before nil check (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 6 months ago by r
Modified:
8 years, 6 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

fmt: set p.field before nil check Fixes issue 3752.

Patch Set 1 #

Patch Set 2 : diff -r 6f2a9ecdccf9 https://code.google.com/p/go #

Patch Set 3 : diff -r 6f2a9ecdccf9 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M src/pkg/fmt/fmt_test.go View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M src/pkg/fmt/print.go View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
8 years, 6 months ago (2012-06-25 23:09:45 UTC) #1
rsc
LGTM
8 years, 6 months ago (2012-06-25 23:44:11 UTC) #2
r
8 years, 6 months ago (2012-06-25 23:48:23 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=5f13e0662e38 ***

fmt: set p.field before nil check
Fixes issue 3752.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6331062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b