export flags on the state of the world when a picture was serialized.

export flags on the state of the world when a picture was serialized.
e.g. don't read/write functionptrs in that case (sizeof may be different for one)
Committed: https://code.google.com/p/skia/source/detail?r=4318

[reed1, 2012-06-22 19:11:05]

patch #2 inits the flags, but those should be set explicitly by the caller if
the buffer comes from serialization.

[bsalomon, 2012-06-22 19:14:07]

https://codereview.appspot.com/6331050/diff/3001/src/core/SkXfermode.cpp
File src/core/SkXfermode.cpp (left):

https://codereview.appspot.com/6331050/diff/3001/src/core/SkXfermode.cpp#oldc...
src/core/SkXfermode.cpp:693: buffer.writeFunctionPtr(NULL);
Should writeFunctionPtr just check x-process and do this for us (and
readFunctionPtr just returns NULL)? Or are there cases where a function pointer
is not really a function pointer?

[bsalomon, 2012-06-22 20:05:22]

LGTM

On 2012/06/22 19:14:07, bsalomon wrote:
> https://codereview.appspot.com/6331050/diff/3001/src/core/SkXfermode.cpp
> File src/core/SkXfermode.cpp (left):
> 
>
https://codereview.appspot.com/6331050/diff/3001/src/core/SkXfermode.cpp#oldc...
> src/core/SkXfermode.cpp:693: buffer.writeFunctionPtr(NULL);
> Should writeFunctionPtr just check x-process and do this for us (and
> readFunctionPtr just returns NULL)? Or are there cases where a function
pointer
> is not really a function pointer?