Issue 6329049: Expand header in serialized pictures

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6329049: Expand header in serialized pictures (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by reed1

Modified:
12 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Expand header in serialized pictures Make chunk/tag reading allow for optional and (somewhat) out-of-order chunks. Return empty picture instead of throwing on error Committed: https://code.google.com/p/skia/source/detail?r=4308

Patch Set 1 #

Patch Set 2 : #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+229 lines, -204 lines)			Patch
M	src/core/SkPicture.cpp	View		2 chunks	+37 lines, -14 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View	1	3 chunks	+19 lines, -2 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View		3 chunks	+173 lines, -188 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages