Fix regexes for importing Linux perf events

In the case of an event with a timestamp of five-digit seconds or greater,
the kernel 3.4-style regex will erroneously match a pre-3.4 event trace.
Also, replace a bunch of ".+" with "\w+" and some other more specific
regexes.

BUG=none
TEST=local build, run on x86

Committed: https://code.google.com/p/trace-viewer/source/detail?r=55

[sheu, 2012-06-22 18:41:12]

Some changes I'm picking up along the way.

[Sam Leffler, 2012-06-22 18:47:08]

run unit tests?

http://codereview.appspot.com/6326047/diff/1/src/linux_perf_importer.js
File src/linux_perf_importer.js (left):

http://codereview.appspot.com/6326047/diff/1/src/linux_perf_importer.js#oldco...
src/linux_perf_importer.js:843: case 'i915_gem_object_change_domain':
did you lose gem_object_change_domain here?

[sheu, 2012-06-22 18:53:52]

Right, unit tests.  I ran them and they're failing.  They're also failing at ToT
with exactly the same failures, so I'll check that out too.

http://codereview.appspot.com/6326047/diff/1/src/linux_perf_importer.js
File src/linux_perf_importer.js (left):

http://codereview.appspot.com/6326047/diff/1/src/linux_perf_importer.js#oldco...
src/linux_perf_importer.js:843: case 'i915_gem_object_change_domain':
It's a duplicate -- it already exists further up.

[Sam Leffler, 2012-06-22 19:17:02]

LGTM

[sheu, 2012-06-22 21:32:45]

While looking into the pre-existing unit test failures, I fixed more bugs. 
Please re-review.

Also, the CL description has changed, but Rietveld doesn't seem to reflect that.

[sheu, 2012-06-22 21:35:33]

Updating description.

[Sam Leffler, 2012-06-22 22:15:56]

LGTM

[nduca, 2012-06-24 23:52:14]

@sheu, would you mind doing a followup and add some unit tests for the changes
you made. It looks like you caught a basic parsing mistake, it should be easy to
add a single line to linux_perf_importer_tests.html that will catch this error.

[sheu, 2012-06-25 08:18:37]

So...

I talked to Sam, and my changes were made against an old version of the parsing
regex that didn't exist at ToT at the time my change was actually applied. 
Thus, the change description is also wrong -- it doesn't touch the 3.4-style
regexes anymore.  I changed the commit description in my trace-viewer git-svn
repo at the time of submit, but when I upload changes, apparently our "git cl"
scripts do not also update the description in the issue.

I will look at adding an extra test in linux_perf_importer_tests.html, but it
doesn't directly affect this change anymore.

[sheu, 2012-06-25 08:18:37]

So...

I talked to Sam, and my changes were made against an old version of the parsing
regex that didn't exist at ToT at the time my change was actually applied. 
Thus, the change description is also wrong -- it doesn't touch the 3.4-style
regexes anymore.  I changed the commit description in my trace-viewer git-svn
repo at the time of submit, but when I upload changes, apparently our "git cl"
scripts do not also update the description in the issue.

I will look at adding an extra test in linux_perf_importer_tests.html, but it
doesn't directly affect this change anymore.

[nduca, 2012-06-25 09:37:33]

Ah, I see. So these are mostly style cleanups?

[Sam Leffler, 2012-06-25 16:18:12]

His changes improve/tighten up parsing (e.g. handling hex values with \w
instead of .+).

On Mon, Jun 25, 2012 at 2:37 AM, <nduca@chromium.org> wrote:

> Ah, I see. So these are mostly style cleanups?
>
>
http://codereview.appspot.com/**6326047/<http://codereview.appspot.com/6326047/>
>

[sheu, 2012-06-25 17:28:16]

Yep.  I thought I had something big (and at the revision I was at, it was a big
bug), but it turns out it had been fixed since.

[nduca, 2012-06-25 17:47:48]

Oh, okay! I get it. Sorry about the confusion, and thank you very much for your
contributions. :)