add PictInfo chunk to serialized pictures

add PictInfo chunk to serialized pictures
Committed: https://code.google.com/p/skia/source/detail?r=4302

[reed1, 2012-06-21 20:46:43]

Don't do anything with the Info yet, but I anticipate exposing some/all of it to
the FlattenableReadBuffer, so that classes can know some info about the stream
they are reading from...

[reed1, 2012-06-21 20:47:39]

I reckon I'll need to bump the picture version, but perhaps less so in the
future, if we can move to more tagged-chunks that don't necessarily have to be
in a certain order...

[bsalomon, 2012-06-21 21:02:52]

https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp
File src/core/SkPicturePlayback.cpp (right):

https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp#...
src/core/SkPicturePlayback.cpp:400: if (PICT_INFO_TAG == tag) {
It does seem like this should loop and skip unknown tags until it sees a finish
tag.

[reed1, 2012-06-21 21:04:54]

agreed.

I might consider doing that in a later CL, since that should be orthogonal to
this change, as it only affects the reader and not the writer. (I think).

Derek, are you in-sync with me adding some/all of PictInfo's data to the
ReadBuffer?

[reed1, 2012-06-21 21:07:25]

patch #2 adds EOF tag at the end

[bsalomon, 2012-06-21 21:19:18]

On 2012/06/21 21:02:52, bsalomon wrote:
> https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp
> File src/core/SkPicturePlayback.cpp (right):
> 
>
https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp#...
> src/core/SkPicturePlayback.cpp:400: if (PICT_INFO_TAG == tag) {
> It does seem like this should loop and skip unknown tags until it sees a
finish
> tag.

Does the writer already write some kind of finish tag?

[reed1, 2012-06-21 21:21:20]

Not until patch #2...

On 2012/06/21 21:19:18, bsalomon wrote:
> On 2012/06/21 21:02:52, bsalomon wrote:
> > https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp
> > File src/core/SkPicturePlayback.cpp (right):
> > 
> >
>
https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp#...
> > src/core/SkPicturePlayback.cpp:400: if (PICT_INFO_TAG == tag) {
> > It does seem like this should loop and skip unknown tags until it sees a
> finish
> > tag.
> 
> Does the writer already write some kind of finish tag?

[bsalomon, 2012-06-21 21:28:32]

On 2012/06/21 21:21:20, reed1 wrote:
> Not until patch #2...

Don't we need the reader to consume the EOF tag?

> 
> On 2012/06/21 21:19:18, bsalomon wrote:
> > On 2012/06/21 21:02:52, bsalomon wrote:
> > >
https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp
> > > File src/core/SkPicturePlayback.cpp (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp#...
> > > src/core/SkPicturePlayback.cpp:400: if (PICT_INFO_TAG == tag) {
> > > It does seem like this should loop and skip unknown tags until it sees a
> > finish
> > > tag.
> > 
> > Does the writer already write some kind of finish tag?

[reed1, 2012-06-22 12:57:25]

On 2012/06/21 21:28:32, bsalomon wrote:
> On 2012/06/21 21:21:20, reed1 wrote:
> > Not until patch #2...
> 
> Don't we need the reader to consume the EOF tag?

Done in patch #3

> 
> > 
> > On 2012/06/21 21:19:18, bsalomon wrote:
> > > On 2012/06/21 21:02:52, bsalomon wrote:
> > > >
> https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp
> > > > File src/core/SkPicturePlayback.cpp (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.appspot.com/6325048/diff/1/src/core/SkPicturePlayback.cpp#...
> > > > src/core/SkPicturePlayback.cpp:400: if (PICT_INFO_TAG == tag) {
> > > > It does seem like this should loop and skip unknown tags until it sees a
> > > finish
> > > > tag.
> > > 
> > > Does the writer already write some kind of finish tag?

[bsalomon, 2012-06-22 13:09:29]

LGTM