Issue 63218: Clean up error handling for proxy code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63218: Clean up error handling for proxy code (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 10 months ago by awiner

Modified:
16 years, 8 months ago

Reviewers:
shindig.remailer

Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 16 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -61 lines)			Patch
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestServlet.java	View	4 chunks	+3 lines, -24 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyBase.java	View	4 chunks	+45 lines, -4 lines	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java	View	2 chunks	+3 lines, -23 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyBaseTest.java	View	6 chunks	+18 lines, -5 lines	0 comments	Download
M	java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

awiner

16 years, 10 months ago (2009-06-09 18:03:12 UTC) #1

A few small changes:
- move error handling out of "proxy" servlets and into the handlers
- handle invalid refresh params
- issue WARNING, not FINE or INFO if a GadgetException comes from an internal
server error (and send a 500, not a 400)

Expand All Messages | Collapse All Messages