Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Issue 63208: Relax CSS restrictions around :visited and :link to the extent possible (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 10 months ago by ihab.awad
Modified:
16 years, 8 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Relax CSS restrictions around :visited and :link selectors to the extent possible

Patch Set 1 #

Patch Set 2 : Ready for review #

Total comments: 4

Patch Set 3 : Added use of Name.css(...) where appropriate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4110 lines, -117 lines) Patch
M build.xml View 1 chunk +11 lines, -0 lines 0 comments Download
M src/com/google/caja/lang/css/CssPropertyPatterns.java View 3 chunks +25 lines, -23 lines 0 comments Download
M src/com/google/caja/plugin/CssRewriter.java View 1 2 6 chunks +188 lines, -25 lines 0 comments Download
M src/com/google/caja/plugin/PluginMessageType.java View 1 chunk +3 lines, -0 lines 0 comments Download
M src/com/google/caja/plugin/bridal.js View 2 chunks +21 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/domita.js View 5 chunks +99 lines, -57 lines 0 comments Download
M tests/com/google/caja/plugin/CssRewriterTest.java View 1 2 2 chunks +28 lines, -2 lines 0 comments Download
M tests/com/google/caja/plugin/domita_test.html View 2 chunks +29 lines, -1 line 0 comments Download
M tests/com/google/caja/plugin/domita_test_untrusted.html View 1 4 chunks +80 lines, -4 lines 0 comments Download
M tests/com/google/caja/plugin/jsunit.js View 1 chunk +8 lines, -4 lines 0 comments Download
A yuitest/dom_test.html View 1 chunk +620 lines, -0 lines 0 comments Download
A yuitest/yahoo-dom.js View 1 chunk +2877 lines, -0 lines 0 comments Download
A yuitest/yahoo_dom_host.html View 1 chunk +121 lines, -0 lines 0 comments Download

Messages

Total messages: 7
ihab.awad
16 years, 10 months ago (2009-06-08 23:21:56 UTC) #1
ihab.awad
16 years, 10 months ago (2009-06-09 04:31:14 UTC) #2
Jasvir
LGTM http://codereview.appspot.com/63208/diff/30/1012 File src/com/google/caja/plugin/CssRewriter.java (right): http://codereview.appspot.com/63208/diff/30/1012#newcode274 Line 274: if (LINK_PSEUDO_CLASSES.contains(ident.getValue())) { Does getValue return canonicalize ...
16 years, 10 months ago (2009-06-10 21:46:23 UTC) #3
ihab.awad
16 years, 10 months ago (2009-06-12 14:56:42 UTC) #4
ihab.awad
http://codereview.appspot.com/63208/diff/30/1012 File src/com/google/caja/plugin/CssRewriter.java (right): http://codereview.appspot.com/63208/diff/30/1012#newcode274 Line 274: if (LINK_PSEUDO_CLASSES.contains(ident.getValue())) { On 2009/06/10 21:46:23, jasvir wrote: ...
16 years, 10 months ago (2009-06-12 15:00:22 UTC) #5
Jasvir
LGTM
16 years, 9 months ago (2009-06-12 20:39:35 UTC) #6
ihab.awad
16 years, 9 months ago (2009-06-18 04:02:34 UTC) #7
@3537.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b