Relax CSS restrictions around :visited and :link to the extent possible

Relax CSS restrictions around :visited and :link selectors to the extent possible

[Jasvir, 2009-06-10 21:46:23]

LGTM

http://codereview.appspot.com/63208/diff/30/1012
File src/com/google/caja/plugin/CssRewriter.java (right):

http://codereview.appspot.com/63208/diff/30/1012#newcode274
Line 274: if (LINK_PSEUDO_CLASSES.contains(ident.getValue())) {
Does getValue return canonicalize strings? I think these need to be lowercased
for comparison.  (See CssTree#927 where idents are set.)

http://codereview.appspot.com/63208/diff/30/1011
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/63208/diff/30/1011#newcode284
Line 284: /-([a-z])/g, function (_, letter) { return letter.toUpperCase(); });
Please canonicalize to lowercase like elsewhere in domita.js (see the "infamous
Turkish locale bug" for why we should do this consistently)

[ihab.awad, 2009-06-12 15:00:22]

http://codereview.appspot.com/63208/diff/30/1012
File src/com/google/caja/plugin/CssRewriter.java (right):

http://codereview.appspot.com/63208/diff/30/1012#newcode274
Line 274: if (LINK_PSEUDO_CLASSES.contains(ident.getValue())) {
On 2009/06/10 21:46:23, jasvir wrote:
> Does getValue return canonicalize strings? I think these need to be lowercased
> for comparison.  (See CssTree#927 where idents are set.)

Confused about CssTree#927 reference -- but point well taken. I added use of
Name.css(...) here and in one other static constant.

http://codereview.appspot.com/63208/diff/30/1011
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/63208/diff/30/1011#newcode284
Line 284: /-([a-z])/g, function (_, letter) { return letter.toUpperCase(); });
On 2009/06/10 21:46:23, jasvir wrote:
> Please canonicalize to lowercase like elsewhere in domita.js (see the
"infamous
> Turkish locale bug" for why we should do this consistently) 

This code is turning, like, "font-width" to "fontWidth", hence the
toUpperCase(). It is basically existing code that I pasted into a shared place
so I could use it twice. Am I missing your point?

[Jasvir, 2009-06-12 20:39:35]

LGTM

[ihab.awad, 2009-06-18 04:02:34]

@3537.