Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(323)

Issue 63167: Add template library resources as needed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 11 months ago by awiner
Modified:
16 years, 9 months ago
Reviewers:
levik, louiscryan
CC:
shindig.remailer_gmail.com
Base URL:
https://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Small improvements for client-side library serialization #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -444 lines) Patch
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java View 1 11 chunks +107 lines, -48 lines 5 comments Download
A java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateLibrary.java View 1 chunk +59 lines, -0 lines 0 comments Download
D java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/NameTagHandler.java View 1 chunk +0 lines, -67 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateContext.java View 3 chunks +13 lines, -0 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateLibrary.java View 1 chunk +8 lines, -190 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateLibraryFactory.java View 1 chunk +1 line, -1 line 0 comments Download
A java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/TemplateResource.java View 1 chunk +72 lines, -0 lines 0 comments Download
A + java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/XmlTemplateLibrary.java View 9 chunks +75 lines, -28 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/TemplateRewriterTest.java View 3 chunks +4 lines, -2 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/RenderTagHandlerTest.java View 2 chunks +6 lines, -4 lines 0 comments Download
D java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/TemplateLibraryTest.java View 1 chunk +0 lines, -89 lines 0 comments Download
A + java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/XmlTemplateLibraryTest.java View 2 chunks +65 lines, -13 lines 0 comments Download

Messages

Total messages: 3
awiner
This takes the unchecked-in-parts of http://codereview.appspot.com/53052 and modifies/simplifies them further. In particular, template library scripts ...
16 years, 11 months ago (2009-05-28 23:43:23 UTC) #1
louiscryan
Generally awesome. One config nit. http://codereview.appspot.com/63167/diff/1001/33 File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java (right): http://codereview.appspot.com/63167/diff/1001/33#newcode111 Line 111: String content = ...
16 years, 11 months ago (2009-05-29 04:37:31 UTC) #2
awiner
16 years, 11 months ago (2009-05-29 21:05:37 UTC) #3
http://codereview.appspot.com/63167/diff/1001/33
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/TemplateRewriter.java
(right):

http://codereview.appspot.com/63167/diff/1001/33#newcode111
Line 111: String content = ResourceLoader.getContent(
On 2009/05/29 04:37:31, louiscryan wrote:
> from container config rather than hardcoded? See line 161 below.

Done.

http://codereview.appspot.com/63167/diff/1001/33#newcode152
Line 152: List<TemplateLibrary> libraries = Lists.newArrayList();
On 2009/05/29 04:37:31, louiscryan wrote:
> Doesn't look like theres a test for these occlusion rules.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b