Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 63110: Change to support user mediated requests in osapi

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 9 months ago by Sachin Shenoy
Modified:
16 years, 8 months ago
Reviewers:
bobevans, louiscryan, awiner
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

https://issues.apache.org/jira/browse/SHINDIG-1065 According to osapi spec any request can be user mediated. (there is no more osapi.ui.*). Shindig to support mechanism for user mediated requests. Changes: - Containers can via configuration let shindig JS know which requests it want to be user mediated. - Predefined hooks are used to pass the request to the container and get the response back. - A new type of request, osapi.newUiRequest is defined to handle user mediated case. Even though this is in global space, it need not be visible to the developer directly. Developer uses the osapi as today. - batch.js is modified to allow handling of user mediated requests. - So that developer can know which request may get user mediated, every request exposes a boolean field userMediated (this is not part of standard but could be good to have something like this for future version). This would allow developers to write code like below, var r = osapi.activites.create(); if (r.userMediated) { // skip creating activity, as I don't want to bug the user. } else { r.execute(); } [Thanks to Shishir for working with me on this change].

Patch Set 1 #

Patch Set 2 : Adding missed one file uirequest.js (adding it). #

Patch Set 3 : Introspect mediated methods from container. #

Patch Set 4 : Fixed couple of bugs "utils" -> "util". "listMethods" -> "system.listMethods". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+516 lines, -96 lines) Patch
features/pom.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
features/src/main/javascript/features/core/util.js View 2 chunks +34 lines, -0 lines 0 comments Download
features/src/main/javascript/features/osapi/batch.js View 1 2 9 chunks +54 lines, -19 lines 0 comments Download
features/src/main/javascript/features/osapi/feature.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
features/src/main/javascript/features/osapi/jsonrequest.js View 1 2 3 4 chunks +3 lines, -31 lines 0 comments Download
features/src/main/javascript/features/osapi/osapi.js View 1 2 3 3 chunks +48 lines, -2 lines 0 comments Download
features/src/main/javascript/features/osapi/uirequest.js View 2 3 1 chunk +141 lines, -0 lines 0 comments Download
features/src/main/javascript/features/osapi/util.js View 1 2 3 1 chunk +64 lines, -34 lines 0 comments Download
features/src/test/javascript/features/alltests.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
features/src/test/javascript/features/osapi/batchtest.js View 1 2 3 3 chunks +162 lines, -4 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4
Sachin Shenoy
16 years, 9 months ago (2009-05-19 19:50:29 UTC) #1
Sachin Shenoy
Adding missed one file uirequest.js (adding it).
16 years, 9 months ago (2009-05-19 19:54:07 UTC) #2
Sachin Shenoy
Introspect mediated methods from container.
16 years, 8 months ago (2009-05-22 11:30:02 UTC) #3
Sachin Shenoy
16 years, 8 months ago (2009-05-22 17:15:06 UTC) #4
Fixed couple of bugs "utils" -> "util". "listMethods" -> "system.listMethods".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b