Issue 63104: Implement Uri.resolve directly rather than using java.net.URI

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63104: Implement Uri.resolve directly rather than using java.net.URI

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by louiscryan

Modified:
16 years, 9 months ago

Reviewers:
shindig.remailer, etnu00

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Description

Using java.net.URI is very inefficient when we have already parsed the uri.

Patch Set 1 #

Patch Set 2 : Try again #

Patch Set 3 : rebased #

Total comments: 1

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -98 lines)			Patch
		java/common/src/main/java/org/apache/shindig/common/uri/Uri.java	View		4 chunks	+132 lines, -98 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

etnu00

16 years, 9 months ago (2009-05-18 22:28:16 UTC) #4

http://codereview.appspot.com/63104/diff/1002/1003
File java/common/src/main/java/org/apache/shindig/common/uri/Uri.java (right):

http://codereview.appspot.com/63104/diff/1002/1003#newcode188
Line 188: private static String normalize(String path) {
This should probably be called normalizePath.

Expand All Messages | Collapse All Messages