Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1485)

Issue 6310065: Treat accidentals parentheses as cautionary (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 3 months ago by Julien Rioux
Modified:
7 years, 2 months ago
CC:
lilypond-devel_gnu.org
Base URL:
http://git.savannah.gnu.org/gitweb/?p=lilypond.git/trunk/
Visibility:
Public.

Description

Treat accidentals parentheses as cautionary Patch from Rodolfo Zitellini

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M scripts/musicxml2ly.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5
MikeSol
LGTM
7 years, 3 months ago (2012-06-20 18:04:12 UTC) #1
Graham Percival
LGTM, although I'd personally have prepended "musicxml2ly:" to the beginning of the patch subject line. ...
7 years, 2 months ago (2012-06-22 08:20:56 UTC) #2
Julien Rioux
On 2012/06/22 08:20:56, Graham Percival wrote: > LGTM, although I'd personally have prepended "musicxml2ly:" to ...
7 years, 2 months ago (2012-06-22 08:58:13 UTC) #3
janek
So until now cautionary accidentals *were* supported - the problem was just that the software ...
7 years, 2 months ago (2012-06-22 15:29:13 UTC) #4
Graham Percival
7 years, 2 months ago (2012-06-24 01:10:29 UTC) #5
On Fri, Jun 22, 2012 at 08:58:13AM +0000, julien.rioux@gmail.com wrote:
> I just did a git am using his patch, but I'll amend the commit before
> pushing. Do we need some license statement from Rodolfo?

No; lilypond is not FSF-copyright-assigned, so nothing is needed.
But thanks for checking!

- Graham
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b