Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(780)

Issue 63088: Make HtmlSerializer injectable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 8 months ago by johnfargo
Modified:
16 years, 6 months ago
Reviewers:
johnfargo
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

Makes it possible to inject an HtmlSerializer via a Provider<HtmlSerializer>, so that serialization can be different on a per-request basis rather than across the board. * Rename HtmlSerializer to HtmlSerialization, removing its abstract methods and keeping static methods handling common Html serialization mechanisms. * Reintroduce HtmlSerializer as a pure interface. * Move NekoSerializer to parse directory renaming it DefaultHtmlSerializer (it uses one Neko class as a helper but is not tied to Neko's parsing in any way). * Move NekoCompactSerializer to CompactHtmlSerializer. Same argument. * Make Provider<HtmlSerializer> injectable in GadgetHtmlParser if so chosen. If not, DefaultHtmlSerializer is always used. * Associated changes to test code.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -618 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/CompactHtmlSerializer.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/DefaultHtmlSerializer.java View 4 chunks +8 lines, -20 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/GadgetHtmlParser.java View 6 chunks +15 lines, -8 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/HtmlSerialization.java View 4 chunks +18 lines, -12 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/HtmlSerializer.java View 1 chunk +6 lines, -98 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/NekoCompactSerializer.java View 1 chunk +0 lines, -112 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/NekoHtmlParser.java View 1 chunk +0 lines, -4 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/NekoSerializer.java View 1 chunk +0 lines, -177 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/nekohtml/NekoSimplifiedHtmlParser.java View 3 chunks +2 lines, -6 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/MutableContent.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/AbstractTagHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessor.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/HtmlTagHandler.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/AbstractParserAndSerializerTest.java View 2 chunks +5 lines, -7 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/CompactHtmlSerializerTest.java View 3 chunks +20 lines, -15 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/ParseTreeSerializerBenchmark.java View 1 chunk +1 line, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/nekohtml/AbstractParserAndSerializerTest.java View 1 chunk +0 lines, -50 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/nekohtml/NekoCompactSerializerTest.java View 1 chunk +0 lines, -88 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/nekohtml/NekoParserAndSerializeTest.java View 1 chunk +1 line, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/nekohtml/NekoParsersTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/nekohtml/SocialMarkupHtmlParserTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/DefaultTemplateProcessorTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/RenderTagHandlerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/TemplateBasedTagHandlerTest.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 1
johnfargo
16 years, 8 months ago (2009-05-15 00:55:13 UTC) #1

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b